[mm-patch]Documentation:reference notifiers.txt in freezing-of-tasks.txt

[mm-patch]Documentation:reference notifiers.txt in freezing-of-tasks.txt

[Oliver Neukum]

Hi,

freezing-of-tasks.txt mentions firmware issues without mentioning the use
of the new notifier API to overcome them. Here's an update.

	Regards
		Oliver
Signed-off-by: Oliver Neukum <oneukum@suse.de>
----

--- a/Documentation/power/freezing-of-tasks.txt	2007-07-09 10:06:51.000000000 +0200
+++ b/Documentation/power/freezing-of-tasks.txt	2007-07-09 10:24:05.000000000 +0200
@@ -155,6 +155,8 @@ Suppose, however, that the firmware file
 only through another device that hasn't been resumed yet.  In that case,
 request_firmware() will fail regardless of whether or not the freezing of tasks
 is used.  Consequently, the problem is not really related to the freezing of
-tasks, since it generally exists anyway.  [The solution to this particular
-problem is to keep the firmware in memory after it's loaded for the first time
-and upload if from memory to the device whenever necessary.]
+tasks, since it generally exists anyway.
+
+A driver must have all firmwares it may need in RAM before suspend() is called.
+If keeping them is not practical, for example due to their size, they must be
+requested early enough using the suspend notifier API described in notifiers.txt.

Re: [mm-patch]Documentation:reference notifiers.txt in freezing-of-tasks.txt

[Rafael J. Wysocki]

Hi,

On Monday, 9 July 2007 10:26, Oliver Neukum wrote:
> Hi,
> 
> freezing-of-tasks.txt mentions firmware issues without mentioning the use
> of the new notifier API to overcome them. Here's an update.
> 
> 	Regards
> 		Oliver
> Signed-off-by: Oliver Neukum <oneukum@suse.de>

Acked-by: Rafael J. Wysocki <rjw@sisk.pl>


-- 
"Premature optimization is the root of all evil." - Donald Knuth

Re: [mm-patch]Documentation:reference notifiers.txt in freezing-of-tasks.txt

[Nigel Cunningham]

[-- Attachment #1.1: Type: text/plain, Size: 1523 bytes --]

Hi.

On Monday 09 July 2007 18:26:19 Oliver Neukum wrote:
> Hi,
> 
> freezing-of-tasks.txt mentions firmware issues without mentioning the use
> of the new notifier API to overcome them. Here's an update.
> 
> 	Regards
> 		Oliver
> Signed-off-by: Oliver Neukum <oneukum@suse.de>
> ----
> 
> --- a/Documentation/power/freezing-of-tasks.txt	2007-07-09 
10:06:51.000000000 +0200
> +++ b/Documentation/power/freezing-of-tasks.txt	2007-07-09 
10:24:05.000000000 +0200
> @@ -155,6 +155,8 @@ Suppose, however, that the firmware file
>  only through another device that hasn't been resumed yet.  In that case,
>  request_firmware() will fail regardless of whether or not the freezing of 
tasks
>  is used.  Consequently, the problem is not really related to the freezing 
of
> -tasks, since it generally exists anyway.  [The solution to this particular
> -problem is to keep the firmware in memory after it's loaded for the first 
time
> -and upload if from memory to the device whenever necessary.]
> +tasks, since it generally exists anyway.
> +
> +A driver must have all firmwares it may need in RAM before suspend() is 
called.

s/firmwares/firmware

> +If keeping them is not practical, for example due to their size, they must 
be
> +requested early enough using the suspend notifier API described in 
notifiers.txt.

Acked-by: Nigel Cunningham <nigel@nigel.suspend2.net>

Regards,

Nigel
-- 
See http://www.tuxonice.net for Howtos, FAQs, mailing
lists, wiki and bugzilla info.

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]