From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 2.6.23-rc1] PM: fix compiler error of PPC dart_iommu Date: Tue, 24 Jul 2007 23:19:54 +0200 Message-ID: <200707242319.55234.rjw@sisk.pl> References: <200707241120.AA00211@paprika.lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <200707241120.AA00211@paprika.lab.ntt.co.jp> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: ryusuke@osrg.net Cc: moriai.satoshi@lab.ntt.co.jp, linux-pm@lists.linux-foundation.org, Johannes Berg , Andrew Morton List-Id: linux-pm@vger.kernel.org On Tuesday, 24 July 2007 13:20, Ryusuke Konishi wrote: > A dummy inline function of register_nosave_region_late was accidentally > removed by the recent PM patch that introduced suspend notifiers. > This elimination causes the following compiler error on PPC machines. > > CC arch/powerpc/sysdev/dart_iommu.o > arch/powerpc/sysdev/dart_iommu.c: In function 'iommu_init_late_dart': > arch/powerpc/sysdev/dart_iommu.c:376: error: implicit declaration of function > 'register_nosave_region_late' > make[1]: *** [arch/powerpc/sysdev/dart_iommu.o] Error 1 > make: *** [arch/powerpc/sysdev] Error 2 > > This patch fixes the problem. > > Signed-off-by: Ryusuke Konishi > --- Acked-by: Rafael J. Wysocki Thanks! > include/linux/suspend.h | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/include/linux/suspend.h b/include/linux/suspend.h > index e8e6da3..618f93c 100644 > --- a/include/linux/suspend.h > +++ b/include/linux/suspend.h > @@ -125,6 +125,9 @@ static inline int unregister_pm_notifier(struct notifier_block *nb) > static inline void register_nosave_region(unsigned long b, unsigned long e) > { > } > +static inline void register_nosave_region_late(unsigned long b, unsigned long e) > +{ > +} > #endif > > #endif /* _LINUX_SWSUSP_H */ > > -- "Premature optimization is the root of all evil." - Donald Knuth