* [2.6 patch] drivers/base/power/: make 2 functions static
@ 2007-07-29 14:56 Adrian Bunk
2007-07-29 16:37 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-07-29 14:56 UTC (permalink / raw)
To: pavel, rjw; +Cc: linux-pm, linux-kernel
suspend_device() and resume_device() can now become static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/base/power/power.h | 6 ------
drivers/base/power/resume.c | 2 +-
drivers/base/power/suspend.c | 2 +-
3 files changed, 2 insertions(+), 8 deletions(-)
--- linux-2.6.23-rc1-mm1/drivers/base/power/power.h.old 2007-07-26 05:14:12.000000000 +0200
+++ linux-2.6.23-rc1-mm1/drivers/base/power/power.h 2007-07-26 05:15:49.000000000 +0200
@@ -55,12 +55,6 @@
extern void dpm_resume(void);
extern void dpm_power_up(void);
-extern int resume_device(struct device *);
-
-/*
- * suspend.c
- */
-extern int suspend_device(struct device *, pm_message_t);
#else /* CONFIG_PM */
--- linux-2.6.23-rc1-mm1/drivers/base/power/resume.c.old 2007-07-26 05:14:28.000000000 +0200
+++ linux-2.6.23-rc1-mm1/drivers/base/power/resume.c 2007-07-26 05:14:39.000000000 +0200
@@ -20,7 +20,7 @@
*
*/
-int resume_device(struct device * dev)
+static int resume_device(struct device * dev)
{
int error = 0;
--- linux-2.6.23-rc1-mm1/drivers/base/power/suspend.c.old 2007-07-26 05:16:00.000000000 +0200
+++ linux-2.6.23-rc1-mm1/drivers/base/power/suspend.c 2007-07-26 05:16:17.000000000 +0200
@@ -54,7 +54,7 @@
* @state: Power state device is entering.
*/
-int suspend_device(struct device * dev, pm_message_t state)
+static int suspend_device(struct device * dev, pm_message_t state)
{
int error = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [2.6 patch] drivers/base/power/: make 2 functions static
2007-07-29 14:56 [2.6 patch] drivers/base/power/: make 2 functions static Adrian Bunk
@ 2007-07-29 16:37 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2007-07-29 16:37 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-pm, linux-kernel
On Sunday, 29 July 2007 16:56, Adrian Bunk wrote:
> suspend_device() and resume_device() can now become static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
Acked-by: Rafael J. Wysocki <rjw@sisk.pl>
> drivers/base/power/power.h | 6 ------
> drivers/base/power/resume.c | 2 +-
> drivers/base/power/suspend.c | 2 +-
> 3 files changed, 2 insertions(+), 8 deletions(-)
>
> --- linux-2.6.23-rc1-mm1/drivers/base/power/power.h.old 2007-07-26 05:14:12.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/base/power/power.h 2007-07-26 05:15:49.000000000 +0200
> @@ -55,12 +55,6 @@
>
> extern void dpm_resume(void);
> extern void dpm_power_up(void);
> -extern int resume_device(struct device *);
> -
> -/*
> - * suspend.c
> - */
> -extern int suspend_device(struct device *, pm_message_t);
>
> #else /* CONFIG_PM */
>
> --- linux-2.6.23-rc1-mm1/drivers/base/power/resume.c.old 2007-07-26 05:14:28.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/base/power/resume.c 2007-07-26 05:14:39.000000000 +0200
> @@ -20,7 +20,7 @@
> *
> */
>
> -int resume_device(struct device * dev)
> +static int resume_device(struct device * dev)
> {
> int error = 0;
>
> --- linux-2.6.23-rc1-mm1/drivers/base/power/suspend.c.old 2007-07-26 05:16:00.000000000 +0200
> +++ linux-2.6.23-rc1-mm1/drivers/base/power/suspend.c 2007-07-26 05:16:17.000000000 +0200
> @@ -54,7 +54,7 @@
> * @state: Power state device is entering.
> */
>
> -int suspend_device(struct device * dev, pm_message_t state)
> +static int suspend_device(struct device * dev, pm_message_t state)
> {
> int error = 0;
>
>
>
>
--
"Premature optimization is the root of all evil." - Donald Knuth
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-29 16:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-29 14:56 [2.6 patch] drivers/base/power/: make 2 functions static Adrian Bunk
2007-07-29 16:37 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox