Re: [PATH 0/1] Kexec jump - v2 - the first step to kexec based hibernation

Pavel Machek
2007-07-31T11:12:08Z

Hi!

> >> >
> >> > +/* Adds the kexec_backup= command line parameter to command line. */
> >> > +static int cmdline_add_backup(char *cmdline, unsigned long addr)
> >> > +{
> >> > + int cmdlen, len, align = 1024;
> >> > + char str[30], *ptr;
> >> > +
> >> > + /* Passing in kexec_backup=xxxK format. Saves space required
> >> > + * in cmdline. Ensure 1K alignment*/
> >> > + if (addr%align)
> >> > + return -1;
> >> > + addr = addr/align;
> >> > + ptr = str;
> >> > + strcpy(str, " kexec_backup=");
> >> > + ptr += strlen(str);
> >> > + ultoa(addr, ptr);
> >> > + strcat(str, "K");
> >> > + len = strlen(str);
> >> > + cmdlen = strlen(cmdline) + len;
> >> > + if (cmdlen > (COMMAND_LINE_SIZE - 1))
> >> > + die("Command line overflow\n");
> >> > + strcat(cmdline, str);
> >> > + return 0;
> >> > +}
> >>
> >> This part did not apply for me -- it seems crashdump related and I did
> >> not have that applied. Is it critical?
> >
> > This is needed for kexec_jump to work properly. Which version of
> > kexec-tools do you use? This patch is against 1.101. The kdump patch
> > must be applied before this patch is applied.
>
> Please work against the kexec-tools-testing tree, if you can.
> All of the outstanding patches should be there.

So
git://git.kernel.org/pub/scm/linux/kernel/git/horms/kexec-tools-testing.git
is the right tree to use?

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html