From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH] x86_64: Save registers in saved_context during suspend and hibernation Date: Tue, 14 Aug 2007 00:52:30 +0200 Message-ID: <20070813225229.GF3406@bingen.suse.de> References: <200708132347.07396.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <200708132347.07396.rjw@sisk.pl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: "Rafael J. Wysocki" Cc: discuss@x86-64.org, pm list , Andi Kleen , Pavel Machek List-Id: linux-pm@vger.kernel.org On Mon, Aug 13, 2007 at 11:47:06PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > During hibernation and suspend on x86_64 save CPU registers in the saved_context > structure rather than in a handful of separate variables. Nice. These variables always annoyed me too when looking at that code. > DEFINE(pbe_next, offsetof(struct pbe, next)); > BLANK(); > + DEFINE(saved_context_rbx, offsetof(struct saved_context, rbx)); But is there a reason you can't just use a pt_regs and then an array for the crNs ? -Andi