Re: [discuss] [PATCH] x86_64: Save registers in saved_context during suspend and hibernation

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Tuesday, 14 August 2007 00:52, Andi Kleen wrote:
> On Mon, Aug 13, 2007 at 11:47:06PM +0200, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> > 
> > During hibernation and suspend on x86_64 save CPU registers in the saved_context
> > structure rather than in a handful of separate variables.
> 
> Nice. These variables always annoyed me too when looking
> at that code.
> 
> >  	DEFINE(pbe_next, offsetof(struct pbe, next));
> >  	BLANK();
> > +	DEFINE(saved_context_rbx, offsetof(struct saved_context, rbx));
> 
> But is there a reason you can't just use a pt_regs and then an array
> for the crNs ? 

Hm, I think I can use pt_regs.  I'll try to redo the patch to use it.

OTOH, crNs already are members of saved_context and are accessed from C.
I wouldn't like to change that code.

Greetings,
Rafael


-- 
"Premature optimization is the root of all evil." - Donald Knuth