From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: discuss@x86-64.org, pm list <linux-pm@lists.linux-foundation.org>,
Andi Kleen <ak@suse.de>
Subject: Re: [discuss] [PATCH] x86_64: Save registers in saved_context during suspend and hibernation
Date: Tue, 14 Aug 2007 21:06:44 +0200 [thread overview]
Message-ID: <20070814190644.GB4182@elf.ucw.cz> (raw)
In-Reply-To: <200708141927.58449.rjw@sisk.pl>
Hi!
> > > Nice. These variables always annoyed me too when looking
> > > at that code.
> > >
> > > > DEFINE(pbe_next, offsetof(struct pbe, next));
> > > > BLANK();
> > > > + DEFINE(saved_context_rbx, offsetof(struct saved_context, rbx));
> > >
> > > But is there a reason you can't just use a pt_regs and then an array
> > > for the crNs ?
> >
> > Hm, I think I can use pt_regs. I'll try to redo the patch to use it.
>
> The updated patch (using pt_regs) is appended.
Looks ok to me.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2007-08-14 19:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-13 21:47 [PATCH] x86_64: Save registers in saved_context during suspend and hibernation Rafael J. Wysocki
2007-08-13 22:52 ` Andi Kleen
2007-08-13 22:26 ` [discuss] " Rafael J. Wysocki
2007-08-14 17:27 ` Rafael J. Wysocki
2007-08-14 19:06 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070814190644.GB4182@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox