Re: [RFC][PATCH -mm 2/4] Hibernation: Turn on ACPI during restore if necessary

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Tuesday, 21 August 2007 09:57, Pavel Machek wrote:
> Hi!
> 
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> > 
> > If the boot kernel doesn't support ACPI and ACPI is not enabled by the platform
> > boot code, it may be possible to enable ACPI after restoring the system memory
> > from a hibernation image.  Implement that.
> 
> ACK... and I guess this should go in early. It is possible to test w/o
> rest of patches, (just pass acpi=off to resume kernel, no?),

Yup, that might work.

> and it  should get lot of testing.

Why do you think so?

Rafael


> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> >  drivers/acpi/sleep/main.c |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > Index: linux-2.6.23-rc3/drivers/acpi/sleep/main.c
> > ===================================================================
> > --- linux-2.6.23-rc3.orig/drivers/acpi/sleep/main.c	2007-08-14 00:41:10.000000000 +0200
> > +++ linux-2.6.23-rc3/drivers/acpi/sleep/main.c	2007-08-19 20:01:05.000000000 +0200
> > @@ -240,6 +240,8 @@ static int acpi_hibernation_enter(void)
> >  
> >  static void acpi_hibernation_finish(void)
> >  {
> > +	/* If the boot kernel doesn't support ACPI, we may need to enable it */
> > +	acpi_enable();
> >  	acpi_leave_sleep_state(ACPI_STATE_S4);
> >  	acpi_disable_wakeup_device(ACPI_STATE_S4);
> >  
> 

-- 
"Premature optimization is the root of all evil." - Donald Knuth