Re: Re: [PATCH -mm 2/2] Hibernation: Arbitrary boot kernel support on x86_64

Johannes Berg
2007-08-25T19:13:45Z

[-- Attachment #1.1: Type: text/plain, Size: 814 bytes --]

On Fri, 2007-08-24 at 16:23 -0700, Andrew Morton wrote:

> The preferred way of doing this is via Kconfig, please. ie: add a
> CONFIG_HIBERNATION_HEADER to arch/x86_64/Kconfig.

> It would be better to do something like this in (say) suspend.h:
>
> #ifdef CONFIG_HIBERNATION_HEADER
> extern int arch_hibernation_header_save(void *addr, unsigned int max_size);
> extern int arch_hibernation_header_restore(void *addr);
> #else
> static inline int arch_hibernation_header_save(void *addr,

In fact, I guess we don't need to bother with this at all. The generic
code for doing this (via the utsname based header) is tiny, so as far as
I can tell it could just be made weak symbols (by this I mean
init_header_complete() and check_image_kernel()), and then all the
#ifdefs can just go.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]