public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: nfs@lists.sourceforge.net, linux-pm@lists.linux-foundation.org,
	chakriin5@gmail.com, linux-kernel@vger.kernel.org,
	a.p.zijlstra@chello.nl
Subject: Re: A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?)
Date: Fri, 28 Sep 2007 13:43:26 -0700	[thread overview]
Message-ID: <20070928134326.e3bb63b1.akpm@linux-foundation.org> (raw)
In-Reply-To: <1191011538.6702.59.camel@heimdal.trondhjem.org>

On Fri, 28 Sep 2007 16:32:18 -0400
Trond Myklebust <trond.myklebust@fys.uio.no> wrote:

> On Fri, 2007-09-28 at 13:10 -0700, Andrew Morton wrote:
> > On Fri, 28 Sep 2007 15:52:28 -0400
> > Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> > 
> > > On Fri, 2007-09-28 at 12:26 -0700, Andrew Morton wrote:
> > > > On Fri, 28 Sep 2007 15:16:11 -0400 Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
> > > > > Looking back, they were getting caught up in
> > > > > balance_dirty_pages_ratelimited() and friends. See the attached
> > > > > example...
> > > > 
> > > > that one is nfs-on-loopback, which is a special case, isn't it?
> > > 
> > > I'm not sure that the hang that is illustrated here is so special. It is
> > > an example of a bog-standard ext3 write, that ends up calling the NFS
> > > client, which is hanging. The fact that it happens to be hanging on the
> > > nfsd process is more or less irrelevant here: the same thing could
> > > happen to any other process in the case where we have an NFS server that
> > > is down.
> > 
> > hm, so ext3 got stuck in nfs via __alloc_pages direct reclaim?
> > 
> > We should be able to fix that by marking the backing device as
> > write-congested.  That'll have small race windows, but it should be a 99.9%
> > fix?
> 
> No. The problem would rather appear to be that we're doing
> per-backing_dev writeback (if I read sync_sb_inodes() correctly), but
> we're measuring variables which are global to the VM. The backing device
> that we are selecting may not be writing out any dirty pages, in which
> case, we're just spinning in balance_dirty_pages_ratelimited().

OK, so it's unrelated to page reclaim.

> Should we therefore perhaps be looking at adding per-backing_dev stats
> too?

That's what mm-per-device-dirty-threshold.patch and friends are doing. 
Whether it works adequately is not really known at this time. 
Unfortunately kernel developers don't test -mm much.  

  parent reply	other threads:[~2007-09-28 20:43 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <92cbf19b0709272332s25684643odaade0e98cb3a1f4@mail.gmail.com>
2007-09-28  6:50 ` A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?) Andrew Morton
     [not found] ` <20070927235034.ae7bd73d.akpm@linux-foundation.org>
2007-09-28  6:59   ` Peter Zijlstra
     [not found]   ` <1190962752.31636.15.camel@twins>
2007-09-28  8:27     ` Chakri n
     [not found]     ` <92cbf19b0709280127yba48b60wfe58e532944894ca@mail.gmail.com>
2007-09-28  8:40       ` Peter Zijlstra
     [not found]       ` <1190968800.31636.26.camel@twins>
2007-09-28  9:01         ` Chakri n
     [not found]         ` <92cbf19b0709280201o3778f945mf1d8d61cbb3d0558@mail.gmail.com>
2007-09-28  9:12           ` Peter Zijlstra
     [not found]           ` <1190970729.31636.29.camel@twins>
2007-09-28  9:20             ` Chakri n
     [not found]             ` <92cbf19b0709280220o7cdd4b1cua37a8776af68ac25@mail.gmail.com>
2007-09-28  9:23               ` Peter Zijlstra
     [not found]               ` <1190971419.31636.38.camel@twins>
2007-09-28 10:36                 ` Chakri n
2007-09-28 13:28   ` Jonathan Corbet
     [not found]   ` <10659.1190986132@lwn.net>
2007-09-28 13:35     ` Peter Zijlstra
2007-09-28 18:04     ` Andrew Morton
     [not found]     ` <1190986542.13204.10.camel@twins>
2007-09-28 16:45       ` Alan Stern
2007-09-29  1:27       ` Daniel Phillips
2007-09-28 17:00   ` Trond Myklebust
     [not found]   ` <1190998853.6702.17.camel@heimdal.trondhjem.org>
     [not found]     ` <20070928114930.2c201324.akpm@linux-foundation.org>
2007-09-28 18:48       ` Peter Zijlstra
2007-09-28 19:16       ` Trond Myklebust
     [not found]       ` <1191005339.18147.89.camel@lappy>
2007-09-28 19:16         ` Andrew Morton
     [not found]       ` <1191006971.6702.25.camel@heimdal.trondhjem.org>
2007-09-28 19:26         ` Andrew Morton
     [not found]         ` <20070928122628.965137f2.akpm@linux-foundation.org>
2007-09-28 19:52           ` Trond Myklebust
     [not found]           ` <1191009148.6702.46.camel@heimdal.trondhjem.org>
2007-09-28 20:10             ` Andrew Morton
2007-09-28 20:24             ` Daniel Phillips
     [not found]             ` <20070928131012.4a03c53e.akpm@linux-foundation.org>
2007-09-28 20:32               ` Trond Myklebust
     [not found]               ` <1191011538.6702.59.camel@heimdal.trondhjem.org>
2007-09-28 20:43                 ` Andrew Morton [this message]
2007-09-28 21:36                   ` Chakri n
     [not found]                   ` <92cbf19b0709281436i41247863t6cbc919c33e972a3@mail.gmail.com>
2007-09-28 23:33                     ` Chakri n
2007-09-29  1:51         ` KDB? Daniel Phillips
2007-09-28 18:49     ` A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?) Andrew Morton
2007-09-29  0:46   ` Daniel Phillips
     [not found] ` <20070929110454.GA29861@mail.ustc.edu.cn>
2007-09-29 11:04   ` Fengguang Wu
     [not found] ` <391063897.19256@ustc.edu.cn>
2007-09-29 11:48   ` Peter Zijlstra
     [not found]   ` <1191066481.18147.115.camel@lappy>
     [not found]     ` <20070929122842.GA5454@mail.ustc.edu.cn>
2007-09-29 12:28       ` Fengguang Wu
     [not found]     ` <391068925.28146@ustc.edu.cn>
2007-09-29 14:43       ` Peter Zijlstra
2007-10-01 15:57   ` Chuck Ebbert
     [not found]   ` <470118EE.1020103@redhat.com>
     [not found]     ` <20071002020040.GA5275@mail.ustc.edu.cn>
2007-10-02  2:00       ` [PATCH] writeback: avoid possible balance_dirty_pages() lockup on a light-load bdi Fengguang Wu
2007-10-03 12:46       ` richard kennedy
     [not found]       ` <1191415612.3123.21.camel@castor.rsk.org>
     [not found]         ` <20071004015053.GA5789@mail.ustc.edu.cn>
2007-10-04  1:50           ` Fengguang Wu
     [not found]     ` <391290444.23950@ustc.edu.cn>
2007-10-02  2:14       ` Andrew Morton
     [not found]         ` <20071002121327.GA5718@mail.ustc.edu.cn>
2007-10-02 12:13           ` Fengguang Wu
     [not found]           ` <20071002132702.GA10967@mail.ustc.edu.cn>
2007-10-02 13:27             ` Fengguang Wu
     [not found]           ` <391331626.16970@ustc.edu.cn>
2007-10-02 18:35             ` Chuck Ebbert
2007-09-28  6:32 A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?) Chakri n

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070928134326.e3bb63b1.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=chakriin5@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=nfs@lists.sourceforge.net \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox