* Re: [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING
[not found] <200710190022.36145.rjw@sisk.pl>
@ 2007-10-18 22:09 ` Nigel Cunningham
2007-10-19 7:55 ` Pavel Machek
1 sibling, 0 replies; 4+ messages in thread
From: Nigel Cunningham @ 2007-10-18 22:09 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: pm list, LKML, Oleg Nesterov
Hi.
On Friday 19 October 2007 08:22:35 Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Do not allow processes to clear their TIF_SIGPENDING if TIF_FREEZE is set,
> to prevent them from racing with the freezer (like mysqld does, for
example).
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Nigel Cunningham <nigel@suspend2.net>
> ---
> kernel/signal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.23-mm1/kernel/signal.c
> ===================================================================
> --- linux-2.6.23-mm1.orig/kernel/signal.c
> +++ linux-2.6.23-mm1/kernel/signal.c
> @@ -124,7 +124,7 @@ void recalc_sigpending_and_wake(struct t
>
> void recalc_sigpending(void)
> {
> - if (!recalc_sigpending_tsk(current))
> + if (!recalc_sigpending_tsk(current) && !freezing(current))
> clear_thread_flag(TIF_SIGPENDING);
>
> }
>
--
Nigel, Michelle, Alisdair and ____________ Cunningham
5 Mitchell Street
Cobden 3266
Victoria, Australia
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING
[not found] <200710190022.36145.rjw@sisk.pl>
2007-10-18 22:09 ` [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING Nigel Cunningham
@ 2007-10-19 7:55 ` Pavel Machek
2007-10-19 21:34 ` Rafael J. Wysocki
1 sibling, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2007-10-19 7:55 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: pm list, Nigel Cunningham, LKML, Oleg Nesterov
On Fri 2007-10-19 00:22:35, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Do not allow processes to clear their TIF_SIGPENDING if TIF_FREEZE is set,
> to prevent them from racing with the freezer (like mysqld does, for example).
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
ACK. We want this in 2.6.24.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING
2007-10-19 7:55 ` Pavel Machek
@ 2007-10-19 21:34 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2007-10-19 21:34 UTC (permalink / raw)
To: Pavel Machek; +Cc: pm list, Nigel Cunningham, LKML, Oleg Nesterov
On Friday, 19 October 2007 09:55, Pavel Machek wrote:
> On Fri 2007-10-19 00:22:35, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > Do not allow processes to clear their TIF_SIGPENDING if TIF_FREEZE is set,
> > to prevent them from racing with the freezer (like mysqld does, for example).
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> ACK. We want this in 2.6.24.
Sure, we do.
Greetings,
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING
@ 2007-10-18 22:22 Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2007-10-18 22:22 UTC (permalink / raw)
To: LKML; +Cc: pm list, Nigel Cunningham, Oleg Nesterov
From: Rafael J. Wysocki <rjw@sisk.pl>
Do not allow processes to clear their TIF_SIGPENDING if TIF_FREEZE is set,
to prevent them from racing with the freezer (like mysqld does, for example).
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
kernel/signal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.23-mm1/kernel/signal.c
===================================================================
--- linux-2.6.23-mm1.orig/kernel/signal.c
+++ linux-2.6.23-mm1/kernel/signal.c
@@ -124,7 +124,7 @@ void recalc_sigpending_and_wake(struct t
void recalc_sigpending(void)
{
- if (!recalc_sigpending_tsk(current))
+ if (!recalc_sigpending_tsk(current) && !freezing(current))
clear_thread_flag(TIF_SIGPENDING);
}
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-10-19 21:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200710190022.36145.rjw@sisk.pl>
2007-10-18 22:09 ` [RFC][PATCH -mm] Freezer: Do not allow freezing processes to clear TIF_SIGPENDING Nigel Cunningham
2007-10-19 7:55 ` Pavel Machek
2007-10-19 21:34 ` Rafael J. Wysocki
2007-10-18 22:22 Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox