hibernate fails to freeze tasks

hibernate fails to freeze tasks

[Johannes Berg]

[-- Attachment #1.1: Type: text/plain, Size: 324 bytes --]

On my quad powermac, with a current git snapshot, hibernating fails to
freeze tasks and then dumps me a snapshot of the tasks. I've uploaded it
here because it's so long:
http://johannes.sipsolutions.net/files/quad-syslog-hibernate-fails

Haven't found time to look into it yet, any ideas are appreciated.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: hibernate fails to freeze tasks

[Rafael J. Wysocki]

On Monday, 22 October 2007 16:22, Johannes Berg wrote:
> On my quad powermac, with a current git snapshot, hibernating fails to
> freeze tasks and then dumps me a snapshot of the tasks. I've uploaded it
> here because it's so long:
> http://johannes.sipsolutions.net/files/quad-syslog-hibernate-fails
> 
> Haven't found time to look into it yet, any ideas are appreciated.

Please try the patch below.

---
From: Rafael J. Wysocki <rjw@sisk.pl>

Do not allow processes to clear their TIF_SIGPENDING if TIF_FREEZE is set,
so that they will not race with the freezer (like mysqld, for example).

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 kernel/signal.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.23/kernel/signal.c
===================================================================
--- linux-2.6.23.orig/kernel/signal.c
+++ linux-2.6.23/kernel/signal.c
@@ -124,7 +124,7 @@ void recalc_sigpending_and_wake(struct t
 
 void recalc_sigpending(void)
 {
-	if (!recalc_sigpending_tsk(current))
+	if (!recalc_sigpending_tsk(current) && !freezing(current))
 		clear_thread_flag(TIF_SIGPENDING);
 
 }

Re: hibernate fails to freeze tasks

[Johannes Berg]

[-- Attachment #1.1: Type: text/plain, Size: 390 bytes --]

On Tue, 2007-10-23 at 00:36 +0200, Rafael J. Wysocki wrote:

> Please try the patch below.

Now it fails at "freezing remaining freezable tasks" (even tries twice.)
This is due to windfarm using
	if (signal_pending() && !try_to_freeze())
and your commit d5d8c5976d6adeddb8208c240460411e2198b393.

I'll post a fix for windfarm, just tested it and it works now, thanks.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Re: hibernate fails to freeze tasks

[Alan Stern]

On Mon, 22 Oct 2007, Johannes Berg wrote:

> On my quad powermac, with a current git snapshot, hibernating fails to
> freeze tasks and then dumps me a snapshot of the tasks. I've uploaded it
> here because it's so long:
> http://johannes.sipsolutions.net/files/quad-syslog-hibernate-fails

This URL gives me "403 - Forbidden".

Alan Stern

Re: hibernate fails to freeze tasks

[Johannes Berg]

[-- Attachment #1.1: Type: text/plain, Size: 434 bytes --]

On Tue, 2007-10-23 at 00:17 -0400, Alan Stern wrote:
> On Mon, 22 Oct 2007, Johannes Berg wrote:
> 
> > On my quad powermac, with a current git snapshot, hibernating fails to
> > freeze tasks and then dumps me a snapshot of the tasks. I've uploaded it
> > here because it's so long:
> > http://johannes.sipsolutions.net/files/quad-syslog-hibernate-fails
> 
> This URL gives me "403 - Forbidden".

Sorry, fixed.

johannes

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]