Re: [PATCH] PM: make freezer optional for suspend

Rafael J. Wysocki
2007-11-15T20:24:24Z

On Thursday, 15 of November 2007, Johannes Berg wrote:
>
> > > > > +config SUSPEND_FREEZER
> > > > > + bool "Enable freezer for suspend to RAM/standby" if ADB_PMU || BROKEN
> > > >
> > > > Hm, is ADB_PMU specific to powerpc?
> > >
> > > Yes, and it's the only code that allows you to suspend w/o the freezer
> > > right now (via PMU specific ioctls)
> >
> > It's a bit confusing for someone who doesn't know what ADB_PMU is.
> >
> > Perhaps it might depend on something like ARCH_CAN_DO_WITHOUT_FREEZER instead?
>
> It can't really. Things break. Ben and Paul just don't want to hear
> about it. I made it depend on BROKEN so people can take it out and see
> what breaks (to possibly fix it), and depend on ADB_PMU so they can have
> their favourite setting without enabling BROKEN.

I understand that, but it's a bit confusing to put ADB_PMU, which is specific
to powerpc, into the generic configuration file.

Greetings,
Rafael