From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Len Brown <len.brown@intel.com>,
linux-pm <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] PM: make freezer optional for suspend
Date: Thu, 15 Nov 2007 21:24:24 +0100 [thread overview]
Message-ID: <200711152124.25136.rjw@sisk.pl> (raw)
In-Reply-To: <1195145246.13846.68.camel@johannes.berg>
On Thursday, 15 of November 2007, Johannes Berg wrote:
>
> > > > > +config SUSPEND_FREEZER
> > > > > + bool "Enable freezer for suspend to RAM/standby" if ADB_PMU || BROKEN
> > > >
> > > > Hm, is ADB_PMU specific to powerpc?
> > >
> > > Yes, and it's the only code that allows you to suspend w/o the freezer
> > > right now (via PMU specific ioctls)
> >
> > It's a bit confusing for someone who doesn't know what ADB_PMU is.
> >
> > Perhaps it might depend on something like ARCH_CAN_DO_WITHOUT_FREEZER instead?
>
> It can't really. Things break. Ben and Paul just don't want to hear
> about it. I made it depend on BROKEN so people can take it out and see
> what breaks (to possibly fix it), and depend on ADB_PMU so they can have
> their favourite setting without enabling BROKEN.
I understand that, but it's a bit confusing to put ADB_PMU, which is specific
to powerpc, into the generic configuration file.
Greetings,
Rafael
next prev parent reply other threads:[~2007-11-15 20:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 19:04 [PATCH] PM: make freezer optional for suspend Johannes Berg
2007-11-14 13:21 ` Rafael J. Wysocki
2007-11-14 14:38 ` Johannes Berg
2007-11-14 21:30 ` Rafael J. Wysocki
2007-11-15 16:47 ` Johannes Berg
2007-11-15 20:24 ` Rafael J. Wysocki [this message]
2007-11-16 15:58 ` Johannes Berg
2007-11-18 18:21 ` Pavel Machek
2007-11-19 14:40 ` Johannes Berg
2007-11-19 16:25 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711152124.25136.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=johannes@sipsolutions.net \
--cc=len.brown@intel.com \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox