From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 0/2] Freezer fixes for 2.6.24 Date: Thu, 22 Nov 2007 17:10:41 +0100 Message-ID: <200711221710.42294.rjw@sisk.pl> References: <200711210244.37965.rjw@sisk.pl> <200711212021.51968.rjw@sisk.pl> <47457EA5.60302@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <47457EA5.60302@gmail.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Franck Bui-Huu Cc: pm list , Nigel Cunningham List-Id: linux-pm@vger.kernel.org On Thursday, 22 of November 2007, Franck Bui-Huu wrote: > Rafael J. Wysocki wrote: > > On Wednesday, 21 of November 2007, Franck Bui-Huu wrote: > >> Rafael J. Wysocki wrote: > >>> The second one is intended to fix the APM emulation breakage caused before > >>> 2.6.23, but unfortunately I can't test it. > >> Why not ? > >> > >> Just hack Kconfig to be able to select this driver on x86 architecture > >> and it should work fine, no ? > > > > Well, I'm afraid I have no suitable userland here ... > > > > I don't have either. > > Anyway I just verified that the current code is broken. I put 2 > processes waiting for a suspend evetn by reading the /dev/apm_bios > device and a third process that does the suspend event by doing an > ioctl() on the apm device. The system doesn't suspend (the kernel > dumped a list of the current tasks, instead of printing "Freezing of > tasks failed after..." BTW) and eventually the third process exits > with an incorrect value: -EINTR. > > Applying your patch makes the previous test case work. IOW, the patch helps? > I also discovered that s2ram doesn't work on my laptop and had to use > standby suspend. I'll try to find out why. Yes, please. Thanks, Rafael