From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] PM: acquire device locks prior to suspending Date: Sat, 15 Dec 2007 01:17:21 +0100 Message-ID: <200712150117.21895.rjw@sisk.pl> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Alan Stern Cc: Andrew Morton , linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org On Friday, 14 of December 2007, Alan Stern wrote: > On Thu, 13 Dec 2007, Andrew Morton wrote: > > > hm, that was all fairly helpful. > > > > This: > > > gives me this: > > > > http://userweb.kernel.org/~akpm/pc131699.jpg > > > > which identifies your culprit: msr. > > > > I'd suggest that the above debug patch be turned into some > > boot-option-enabled thing and that it be rolled out with this locking > > change for a while at least. > > Rafael, that looks like exactly the same sort of problem as we saw > before. Global searching for CPU_DEAD_FROZEN shows several other > places that perhaps also could be simplified; the actions they take may > or may not be needed for hibernation. > > The following three seem definitely dangerous: > > arch/x86/kernel/cpu/mcheck/mce_64.c > arch/x86/kernel/cpuid.c > arch/x86/kernel/msr.c > > And of course the third is the one that Andrew spotted. Would you like > to address them? Yes, I think I can take care of them, but not earlier than on Sunday. > I can package up Andrew's debugging changes into a real patch. Yes, that certainly is worth doing. :-) Thanks, Rafael