public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: pm list <linux-pm@lists.linux-foundation.org>
Cc: Pavel Machek <pavel@suse.cz>, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>
Subject: [PATCH] Hibernation: Document __save_processor_state() on x86-64
Date: Fri, 28 Dec 2007 13:53:37 +0100	[thread overview]
Message-ID: <200712281353.37976.rjw@sisk.pl> (raw)

From: Rafael J. Wysocki <rjw@sisk.pl>

Document the fact that __save_processor_state() has to save all CPU
registers referred to by the kernel in case a different kernel is
used to load and restore a hibernation image containing it. 

Sigend-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 arch/x86/kernel/suspend_64.c |   20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Index: linux-2.6/arch/x86/kernel/suspend_64.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/suspend_64.c
+++ linux-2.6/arch/x86/kernel/suspend_64.c
@@ -19,6 +19,21 @@ extern const void __nosave_begin, __nosa
 
 struct saved_context saved_context;
 
+/**
+ *	__save_processor_state - save CPU registers before creating a
+ *		hibernation image and before restoring the memory state from it
+ *	@ctxt - structure to store the registers contents in
+ *
+ *	NOTE: If there is a CPU register the modification of which by the
+ *	boot kernel (ie. the kernel used for loading the hibernation image)
+ *	might affect the operations of the restored target kernel (ie. the one
+ *	saved in the hibernation image), then its contents must be saved by this
+ *	function.  In other words, if kernel A is hibernated and different
+ *	kernel B is used for loading the hibernation image into memory, the
+ *	kernel A's __save_processor_state() function must save all registers
+ *	needed by kernel A, so that it can operate correctly after the resume
+ *	regardless of what kernel B does in the meantime.
+ */
 void __save_processor_state(struct saved_context *ctxt)
 {
 	kernel_fpu_begin();
@@ -69,6 +84,11 @@ static void do_fpu_end(void)
 	kernel_fpu_end();
 }
 
+/**
+ *	__restore_processor_state - restore the contents of CPU registers saved
+ *		by __save_processor_state()
+ *	@ctxt - structure to load the registers contents from
+ */
 void __restore_processor_state(struct saved_context *ctxt)
 {
 	/*

             reply	other threads:[~2007-12-28 12:53 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-28 12:53 Rafael J. Wysocki [this message]
2007-12-29 23:43 ` [PATCH] Hibernation: Document __save_processor_state() on x86-64 Pavel Machek
     [not found] ` <20071229234326.GA17807@ucw.cz>
2007-12-30 13:30   ` Rafael J. Wysocki
     [not found]   ` <200712301430.08274.rjw@sisk.pl>
2007-12-30 20:17     ` Pavel Machek
2007-12-30 14:21 ` Ingo Molnar
     [not found] ` <20071230142109.GK16946@elte.hu>
     [not found]   ` <200712302204.56977.rjw@sisk.pl>
2007-12-30 20:51     ` Ingo Molnar
     [not found]     ` <20071230205104.GB26120@elte.hu>
     [not found]       ` <200712302248.03567.rjw@sisk.pl>
2007-12-30 21:31         ` Ingo Molnar
     [not found]         ` <20071230213126.GB14654@elte.hu>
     [not found]           ` <200712302308.51562.rjw@sisk.pl>
2007-12-30 21:57             ` Ingo Molnar
2007-12-30 22:37               ` Rafael J. Wysocki
2007-12-31  9:29               ` Torsten Kaiser
     [not found]               ` <200712302337.23896.rjw@sisk.pl>
2007-12-31 10:43                 ` Ingo Molnar
     [not found]                 ` <20071231104311.GA30003@elte.hu>
2007-12-31 17:57                   ` Rafael J. Wysocki
2007-12-30 22:08           ` Rafael J. Wysocki
2007-12-30 21:48       ` Rafael J. Wysocki
2007-12-30 21:04   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200712281353.37976.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox