From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: kernel list <linux-kernel@vger.kernel.org>,
Linux-pm mailing list <linux-pm@lists.osdl.org>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: wakeup code translated to .c
Date: Mon, 4 Feb 2008 00:56:09 +0100 [thread overview]
Message-ID: <20080203235608.GH2799@elf.ucw.cz> (raw)
In-Reply-To: <200802040020.14836.rjw@sisk.pl>
Hi!
> Below is the arch/x86/kernel/acpi/sleep.c part without the warnings (untested).
>
> It still contains some hardcoded magic numbers and extern declarations, so
> I guess the #include list is not complete or another header is necessary.
>
> BTW:
> 1) why exactly is acpi_wakeup_address not (void *)?
> 2) header->level3_ident_pgt and header->level3_ident_pgt could be (char *) IMO
I applied it, and renamed acpi/rm to acpi/realmode... yep, rm was a
bad name.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-02-03 23:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-30 12:01 wakeup code translated to .c Pavel Machek
2008-02-03 17:57 ` Rafael J. Wysocki
2008-02-03 18:16 ` Pavel Machek
2008-02-03 18:24 ` Rafael J. Wysocki
2008-02-03 18:49 ` Sam Ravnborg
2008-02-03 20:02 ` H. Peter Anvin
2008-02-03 22:24 ` Pavel Machek
2008-02-03 22:27 ` Sam Ravnborg
2008-02-04 12:44 ` Pavel Machek
2008-02-03 22:33 ` Rafael J. Wysocki
2008-02-03 23:20 ` Rafael J. Wysocki
2008-02-03 23:30 ` [linux-pm] " Rafael J. Wysocki
2008-02-03 23:33 ` Pavel Machek
2008-02-03 23:54 ` Rafael J. Wysocki
2008-02-03 23:59 ` Pavel Machek
2008-02-03 23:59 ` Rafael J. Wysocki
2008-02-04 0:05 ` Pavel Machek
2008-02-03 23:56 ` Pavel Machek [this message]
2008-02-03 23:57 ` Pavel Machek
2008-02-03 23:57 ` Rafael J. Wysocki
2008-02-04 0:18 ` Pavel Machek
2008-02-03 23:58 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080203235608.GH2799@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox