From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: wakeup code translated to .c Date: Mon, 4 Feb 2008 00:56:09 +0100 Message-ID: <20080203235608.GH2799@elf.ucw.cz> References: <20080130120111.GB22820@elf.ucw.cz> <20080203181648.GA1629@elf.ucw.cz> <200802032333.02821.rjw@sisk.pl> <200802040020.14836.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <200802040020.14836.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: kernel list , Linux-pm mailing list , "H. Peter Anvin" List-Id: linux-pm@vger.kernel.org Hi! > Below is the arch/x86/kernel/acpi/sleep.c part without the warnings (untested). > > It still contains some hardcoded magic numbers and extern declarations, so > I guess the #include list is not complete or another header is necessary. > > BTW: > 1) why exactly is acpi_wakeup_address not (void *)? > 2) header->level3_ident_pgt and header->level3_ident_pgt could be (char *) IMO I applied it, and renamed acpi/rm to acpi/realmode... yep, rm was a bad name. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html