Re: wakeup code translated to .c

Pavel Machek
2008-02-03T22:24:07Z

On Sun 2008-02-03 19:49:31, Sam Ravnborg wrote:
> On Sun, Feb 03, 2008 at 07:16:48PM +0100, Pavel Machek wrote:
> > Hi!
> >
> > > > This version works on 32-bit, and builds on 64-bit (but I'm pretty
> > > > sure it does not work. 32-bit code probably needs to go into rm/....)
> > > >
> > >
> > > Do you have an updated version or is this the latest one?
> >
> > I'm glad you ask ;-). Here's reasonably-recent version (I have
> > slightly cleaner one, but it got obscured by 2.6.24-git merge), I
> > eventually got it to work on 64-bit, by reusing trampoline.S code.
> >
> > Pavel
> > Signed-off-by: Pavel Machek <pavel@suse.cz>
>
> Hi PAvel.
>
> Before you submit this for real we need me to take a deper
> look into your Makefiles.

Ok, lets get this right.

> We do not want this duplication between boot and acpi.
> And the way you deal with code sharing from boot/ is not
> OK either.

Well, current version has one copy in .c, then two duplicate .S
version, based on older code.... so few duplicate Makefiles do not
seem like huge deal.
Pavel