From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [linux-pm] Re: [rft] s2ram wakeup moves to .c, could fix few machines Date: Fri, 8 Feb 2008 22:31:01 +0100 Message-ID: <20080208213101.GE12923@elf.ucw.cz> References: <20080208210004.GA12923@elf.ucw.cz> <20080208212317.GD12923@elf.ucw.cz> <47ACC942.1020308@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <47ACC942.1020308@zytor.com> Sender: linux-kernel-owner@vger.kernel.org To: "H. Peter Anvin" Cc: Alan Stern , "Rafael J. Wysocki" , Linux-pm mailing list , kernel list List-Id: linux-pm@vger.kernel.org On Fri 2008-02-08 13:27:30, H. Peter Anvin wrote: > Pavel Machek wrote: >> >> See arch/x86/kernel/acpi/realmode/wakeup.S (the version that was sent >> to the list). No problem there, but table stored at nonzero >> offset. Short jump at the beggining of table would fix it (ugly). >> > > Ugly, but it's the standard way to deal. We have it in the bzImage format, > too. I'd prefer to keep it as it is, there are no problems. This way, we can put debugging instructions at the first byte of wakeup code, which is somehow important. Plus, with right #defines, it should be clean enough. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html