From: Pavel Machek <pavel@ucw.cz>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: gregkh@suse.de, greg@kroah.com, linux-kernel@vger.kernel.org,
linux-pm@lists.osdl.org
Subject: Re: [linux-pm] patch power_state-remove-it-from-usb.patch added to gregkh-2.6 tree
Date: Thu, 21 Feb 2008 23:22:02 +0100 [thread overview]
Message-ID: <20080221222202.GB25977@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0802211717230.4990-100000@iolanthe.rowland.org>
On Thu 2008-02-21 17:18:32, Alan Stern wrote:
> On Thu, 21 Feb 2008 gregkh@suse.de wrote:
>
> > This is a note to let you know that I've just added the patch titled
> >
> > Subject: power_state: remove it from usb
> >
> > to my gregkh-2.6 tree. Its filename is
> >
> > power_state-remove-it-from-usb.patch
> >
> > This tree can be found at
> > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/
> >
> >
> > From pavel@ucw.cz Thu Feb 21 13:36:03 2008
> > From: Pavel Machek <pavel@ucw.cz>
> > Date: Thu, 21 Feb 2008 14:01:45 +0100
> > Subject: power_state: remove it from usb
> > To: kernel list <linux-kernel@vger.kernel.org>, Linux-pm mailing list <linux-pm@lists.osdl.org>, Greg KH <greg@kroah.com>, stern@rowland.harvard.edu, linux-usb@vger.kernel.org
> > Message-ID: <20080221130145.GA3789@elf.ucw.cz>
> > Content-Disposition: inline
> >
> >
> >
> > power_state is scheduled for removal, and it is used only write-only
> > by USB. Remove it.
>
> Greg, this patch is incomplete. Some of the settings that Pavel
> removed are used by the host controller drivers. Please revert this;
> I'll send a more complete patch later.
Alan is right, I was blind... and my config was not affected...
...
host/sl811-hcd.c: if (dev->dev.power.power_state.event == PM_EVENT_SUSPEND
misc/usbtest.c: if (intf->dev.power.power_state.event != PM_EVENT_ON) {
...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-02-21 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 13:01 power_state: remove it from usb Pavel Machek
2008-02-21 21:43 ` patch power_state-remove-it-from-usb.patch added to gregkh-2.6 tree gregkh
2008-02-21 22:18 ` [linux-pm] " Alan Stern
2008-02-21 22:22 ` Pavel Machek [this message]
2008-02-21 22:33 ` Greg KH
[not found] ` <20080221130145.GA3789-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2008-02-21 21:50 ` power_state: remove it from usb Alan Stern
[not found] ` <Pine.LNX.4.44L0.0802211648530.2114-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2008-02-21 22:19 ` Pavel Machek
[not found] ` <20080221221950.GA25977-I/5MKhXcvmPrBKCeMvbIDA@public.gmane.org>
2008-02-21 22:37 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080221222202.GB25977@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.osdl.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox