Re: BUG in include/linux/pm.h: remote wakeup settings

Rafael J. Wysocki
2008-03-10T15:06:37Z

On Monday, 10 of March 2008, Alan Stern wrote:
> Currently include/linux/pm.h doesn't define the should_wakeup field in
> dev_pm_info, or the related accessor macros, unless CONFIG_PM_SLEEP is
> set.
>
> This is wrong. Even though the system can't go to sleep, individual
> devices may be placed in low-power states (runtime PM). Thus the
> various wakeup settings should be available whenever CONFIG_PM is on.
>
> I don't want to submit a patch to fix the problem right now, because it
> would clash with ongoing changes that Rafael is making. But the bug
> needs to be fixed in time for 2.6.26.

Well, I'm going to prepare a "for 2.6.26" series of patches to send to Greg
(that won't include the "separate suspend and hibernation callbacks" patch
yet).

If you post a patch for this (with a changelog and s-o-b), I'll rebase it (if
necessary) add it to the series.

Thanks,
Rafael