public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Linux-pm mailing list <linux-pm@lists.linux-foundation.org>
Subject: Re: BUG in include/linux/pm.h: remote wakeup settings
Date: Mon, 10 Mar 2008 16:06:37 +0100	[thread overview]
Message-ID: <200803101606.37723.rjw@sisk.pl> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0803101011540.3493-100000@iolanthe.rowland.org>

On Monday, 10 of March 2008, Alan Stern wrote:
> Currently include/linux/pm.h doesn't define the should_wakeup field in 
> dev_pm_info, or the related accessor macros, unless CONFIG_PM_SLEEP is 
> set.
> 
> This is wrong.  Even though the system can't go to sleep, individual
> devices may be placed in low-power states (runtime PM).  Thus the
> various wakeup settings should be available whenever CONFIG_PM is on.
> 
> I don't want to submit a patch to fix the problem right now, because it
> would clash with ongoing changes that Rafael is making.  But the bug
> needs to be fixed in time for 2.6.26.

Well, I'm going to prepare a "for 2.6.26" series of patches to send to Greg
(that won't include the "separate suspend and hibernation callbacks" patch
yet).

If you post a patch for this (with a changelog and s-o-b), I'll rebase it (if
necessary) add it to the series.

Thanks,
Rafael

  reply	other threads:[~2008-03-10 15:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-10 14:18 BUG in include/linux/pm.h: remote wakeup settings Alan Stern
2008-03-10 15:06 ` Rafael J. Wysocki [this message]
2008-03-10 18:44   ` [PATCH] PM: make wakeup flags available whenever CONFIG_PM is set Alan Stern
2008-03-10 16:53 ` BUG in include/linux/pm.h: remote wakeup settings David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803101606.37723.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox