Re: suspend slow in 2.6.25-rc6 (was Re: Suspend and hibernation patchset against -rc6)

Pavel Machek
2008-03-18T23:05:38Z

Hi!

> > should not take too long to check which commit it is. Even if it should
> > take 9 reboots to bisect it entirely, going just five or six will likely
> > narrow it down sufficiently that we can probably guess fairly well what
> > it's about.
>
> Hmm, it gets weirder. 2.6.25-rc5 was fast, and had small problem with
> backlight hotkeys did not work.
>
> 2.6.25-rc6 has backlight hotkeys somehow working, but closing/opening lid in X
> kills the backlight, making machine unusable.
>
> Hmm...
>
> commit 7c0ea45be4f114d85ee35caeead8e1660699c46f
> tree 0822ef23606a733e00bbf75d3e218b1e92abdd78
> parent 2f44bbb495dd3e6d0209eff2257438ab9c570e5b
> author Zhao Yakui <yakui.zhao@intel.com> Tue, 11 Mar 2008 16:56:47
> +0800
> committer Len Brown <len.brown@intel.com> Tue, 11 Mar 2008 22:20:19
> -0400
>
> ACPI: Ignore _BQC object when registering backlight device
>
> According to acpi spec , the objects of _BCL and _BCM are
> required if
> integrated LCD is present and supports brightness level .The _BQC
> is
> the optional object. So the _BQC object is ignored when the
> backlight device
> is registered in ACPI video driver.
>
> http://bugzilla.kernel.org/show_bug.cgi?id=10206
>
> Signed-off-by: Zhao Yakui <yakui.zhao@intel.com>
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> Signed-off-by: Len Brown <len.brown@intel.com>
>
>
> when did this go in? Pretty recently, right? And that means that ACPI
> backlight driver is now used on machines where it was not used
> before...?

No, this commit was not responsible, but CONFIG_ACPI_VIDEO *is*
responsible for the "X has no backlight after lid close/open".
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/