Re: suspend slow in 2.6.25-rc6 (was Re: Suspend and hibernation patchset against -rc6)

Pavel Machek
2008-03-19T11:49:24Z

> Pavel Machek wrote:
> >On Tue 2008-03-18 10:31:28, Linus Torvalds wrote:
> >>
> >>On Tue, 18 Mar 2008, Pavel Machek wrote:
> >>>On Tue 2008-03-18 14:06:42, Pavel Machek wrote:
> >>>>Confirmed, suspend slowness is in 2.6.25-rc6, too. It takes 15 seconds
> >>>>to suspend/resume, while 2.6.24 takes 9. Thinkpad x60.
> >>>IIRC 2.6.25-rc5 was "fast".
> >>Can you bisect it? There's only 343 commits between -rc5 and -rc6, so it
> >>should not take too long to check which commit it is. Even if it should
> >>take 9 reboots to bisect it entirely, going just five or six will likely
> >>narrow it down sufficiently that we can probably guess fairly well what
> >>it's about.
> >
> >Slowdown is fixed by this patch:
> I think only this part is relevant here. But yes, I agree that the whole
> patch should be reverted.
> >@@ -230,7 +227,6 @@ static int acpi_ec_wait(struct acpi_ec *
> > while (time_before(jiffies, delay)) {
> > if (acpi_ec_check_status(ec, event))
> > goto end;
> >- msleep(5);
> > }
> > }
> > pr_err(PREFIX "acpi_ec_wait timeout,"
> Thanks,
> Alex.

> ACPI: EC: Revert storm handler patch
>
> From: Alexey Starikovskiy <astarikovskiy@suse.de>
>
> Patch have caused several new troubles, so just revert it for now.
>
> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>

Tested-by: Pavel Machek <pavel@suse.cz>
ACK.
Pavel