Re: [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks

Pavel Machek
2008-03-18T23:54:57Z

Hi!

> > So... we do prepare() but it detects new child, so it returns -EAGAIN.
> > so we call complete() based on description above
> > ...and then we call prepare() to suspend again?
>
> You misunderstood (maybe the comment needs to be clarified as above).

Yes, please :-).

> If prepare() returns any error (including -EAGAIN) then complete() does
> not get called. If prepare() returns successfully but the PM core
> detects that a new child was added while prepare() was running, then we
> call complete(), suspend the child, and call prepare() again.

Ok.

> > > + * @suspend: Executed before putting the system into a sleep state in which the
> > > + * contents of main memory are preserved. Quiesce the device, put it into
> >
> > content....is?
>
> It's okay to use "contents" -- analogous to the table of contents in a
> book. It's one of those weird corner cases where either alternative is
> acceptable.

Ok -- I guess I should get that english course ;-).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/