From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH 0/11] PCI PM: Handling of PCI devices wake-up functionality
Date: Wed, 25 Jun 2008 15:05:08 -0700 [thread overview]
Message-ID: <200806251505.08603.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <200806231934.08565.rjw@sisk.pl>
On Monday, June 23, 2008 10:34 am Rafael J. Wysocki wrote:
> Hi,
>
> The purpose of the following series of patches is to rework the power
> management of PCI devices so that the handling of their wake-up
> functionality is consistent with the other PM operations and so that the
> user space can manage the wake-up functionality of PCI devices using the
> /sys/devices/.../power/wakeup interface regardless of whether the wake-up
> function is based on the native PCI mechanism (PME#), or it is handled by
> the platform (eg. ACPI).
>
> Apart from the ACPI and PCI changes necessary for this purpose, the series
> includes some clean-ups that are not strictly required, but make the code
> more straightforward and (IMHO) easier to follow.
>
> Please review.
This patchset looks really nice, and makes pci_enable_wake and such much more
readable, IMO. How much testing has it seen? Do you think it's appropriate
for 2.6.27?
Thanks,
Jesse
next prev parent reply other threads:[~2008-06-25 22:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200806231934.08565.rjw@sisk.pl>
2008-06-23 17:44 ` [PATCH 10/11] PCI PM: Introduce pci_prepare_to_sleep and pci_back_from_sleep Rafael J. Wysocki
2008-06-23 17:45 ` [PATCH 01/11] ACPI: Introduce acpi_bus_power_manageable function Rafael J. Wysocki
2008-06-23 17:45 ` [PATCH 02/11] PCI: Introduce platform_pci_power_manageable function Rafael J. Wysocki
2008-06-23 17:45 ` [PATCH 03/11] PCI: Rework pci_set_power_state function (rev. 3) Rafael J. Wysocki
2008-06-23 17:45 ` [PATCH 04/11] ACPI: Introduce acpi_device_sleep_wake function Rafael J. Wysocki
2008-06-23 17:45 ` [PATCH 05/11] ACPI: Introduce new device wakeup flag 'prepared' Rafael J. Wysocki
2008-06-23 17:45 ` [PATCH 06/11] PCI ACPI: Introduce acpi_pm_device_sleep_wake function Rafael J. Wysocki
2008-06-23 17:46 ` [PATCH 07/11] PCI ACPI: Introduce can_wakeup platform callback Rafael J. Wysocki
2008-06-23 17:46 ` [PATCH 08/11] PCI PM: Rework device PM initialization (rev. 3) Rafael J. Wysocki
2008-06-23 17:46 ` [PATCH 09/11] ACPI: Make ACPI update wake-up capability flag for devices that can wake up Rafael J. Wysocki
2008-06-23 17:49 ` [PATCH 11/11] PCI: Simplify PCI device PM code Rafael J. Wysocki
2008-06-25 22:05 ` Jesse Barnes [this message]
2008-06-25 22:24 ` [PATCH 0/11] PCI PM: Handling of PCI devices wake-up functionality Rafael J. Wysocki
[not found] ` <200806231945.00404.rjw@sisk.pl>
2008-07-07 7:02 ` [PATCH 10/11] PCI PM: Introduce pci_prepare_to_sleep and pci_back_from_sleep Pavel Machek
[not found] ` <200806231945.19574.rjw@sisk.pl>
2008-07-07 7:03 ` [PATCH 01/11] ACPI: Introduce acpi_bus_power_manageable function Pavel Machek
[not found] ` <200806231945.26068.rjw@sisk.pl>
2008-07-07 7:05 ` [PATCH 02/11] PCI: Introduce platform_pci_power_manageable function Pavel Machek
[not found] ` <200806231945.32682.rjw@sisk.pl>
2008-07-07 7:15 ` [PATCH 03/11] PCI: Rework pci_set_power_state function (rev. 3) Pavel Machek
[not found] ` <200806231945.39951.rjw@sisk.pl>
2008-07-07 7:18 ` [PATCH 04/11] ACPI: Introduce acpi_device_sleep_wake function Pavel Machek
[not found] ` <200806231945.47937.rjw@sisk.pl>
2008-07-07 7:20 ` [PATCH 05/11] ACPI: Introduce new device wakeup flag 'prepared' Pavel Machek
2008-06-23 17:34 [PATCH 0/11] PCI PM: Handling of PCI devices wake-up functionality Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806251505.08603.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox