From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Zhao Yakui <yakui.zhao@intel.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Pavel Machek <pavel@suse.cz>, Andi Kleen <andi@firstfloor.org>,
pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: PCI PM: Fix pci_prepare_to_sleep
Date: Mon, 14 Jul 2008 14:27:33 -0700 [thread overview]
Message-ID: <200807141427.34022.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <200807132245.07414.rjw@sisk.pl>
On Sunday, July 13, 2008 1:45 pm Rafael J. Wysocki wrote:
> Hi Jesse,
>
> The recently introduced pci_prepare_to_sleep() needs the following fix,
> because there are systems which are not power manageable by ACPI (ie. ACPI
> doesn't provide methods to put the device into low power states and back),
> but require ACPI hooks to be executed for wake-up to work.
>
> Please apply.
>
> Thanks,
> Rafael
>
> ---
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Fix pci_prepare_to_sleep() to work on systems that are not power
> manageable by ACPI (ie. ACPI doesn't provide methods to put the
> device into low power states and back into the full power state), but
> require ACPI hooks to be executed for wake-up to work.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Based on what you've told me so far about the number of ACPI vs. native wakeup
methods & problems, I'm starting to get a little worried that making this
stuff work right will require lots of platform specific quirks. I guess
that's just par for the course though, and this patch looks fine, so I just
applied it to my linux-next branch.
Thanks,
Jesse
next prev parent reply other threads:[~2008-07-14 21:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200807012356.26669.rjw@sisk.pl>
2008-07-01 22:00 ` [PATCH 1/9] PCI ACPI: Remove acpi_platform_enable_wakeup Rafael J. Wysocki
2008-07-01 22:03 ` [PATCH 2/9] ACPI: Introduce acpi_bus_power_manageable function Rafael J. Wysocki
2008-07-01 22:04 ` [PATCH 3/9] PCI: Introduce platform_pci_power_manageable function Rafael J. Wysocki
2008-07-01 22:05 ` [PATCH 4/9] PCI: Rework pci_set_power_state function (rev. 3) Rafael J. Wysocki
2008-07-01 22:06 ` [PATCH 5/9] ACPI: Introduce acpi_device_sleep_wake function Rafael J. Wysocki
2008-07-01 22:07 ` [PATCH 6/9] ACPI: Introduce new device wakeup flag 'prepared' Rafael J. Wysocki
2008-07-01 22:08 ` [PATCH 7/9] PCI ACPI: Rework PCI handling of wake-up (rev. 4) Rafael J. Wysocki
2008-07-01 22:09 ` [PATCH 8/9] PCI PM: Introduce pci_prepare_to_sleep and pci_back_from_sleep Rafael J. Wysocki
2008-07-01 22:10 ` [PATCH 9/9] PCI: Simplify PCI device PM code (rev. 4) Rafael J. Wysocki
[not found] ` <200807020008.44033.rjw@sisk.pl>
2008-07-02 7:30 ` [PATCH 7/9] PCI ACPI: Rework PCI handling of wake-up " Zhao Yakui
[not found] ` <1214983804.6559.26.camel@yakui_zhao.sh.intel.com>
2008-07-02 10:16 ` Rafael J. Wysocki
2008-07-03 12:04 ` [PATCH 0/9] PCI PM: Handling of PCI devices wake-up functionality (rev. 3) Rafael J. Wysocki
2008-07-07 1:30 ` [PATCH 0/8] PCI PM: Handling of PCI devices wake-up functionality (rev. 4) Rafael J. Wysocki
[not found] ` <200807070330.02849.rjw@sisk.pl>
2008-07-07 1:30 ` [PATCH 1/8] ACPI: Introduce acpi_bus_power_manageable function Rafael J. Wysocki
2008-07-07 1:32 ` [PATCH 2/8] PCI: Introduce platform_pci_power_manageable function Rafael J. Wysocki
2008-07-07 1:32 ` [PATCH 3/8] PCI: Rework pci_set_power_state function (rev. 4) Rafael J. Wysocki
2008-07-07 1:33 ` [PATCH 4/8] ACPI: Introduce acpi_device_sleep_wake function Rafael J. Wysocki
2008-07-07 1:34 ` [PATCH 5/8] ACPI: Introduce new device wakeup flag 'prepared' Rafael J. Wysocki
2008-07-07 1:34 ` [PATCH 6/8] PCI ACPI: Rework PCI handling of wake-up (rev. 5) Rafael J. Wysocki
2008-07-07 1:35 ` [PATCH 7/8] PCI PM: Introduce pci_prepare_to_sleep and pci_back_from_sleep Rafael J. Wysocki
2008-07-07 1:36 ` [PATCH 8/8] PCI: Simplify PCI device PM code (rev. 4) Rafael J. Wysocki
[not found] ` <200807070334.12948.rjw@sisk.pl>
2008-07-07 14:08 ` [PATCH 5/8] ACPI: Introduce new device wakeup flag 'prepared' Pavel Machek
2008-07-08 0:49 ` [PATCH 0/8] PCI PM: Handling of PCI devices wake-up functionality (rev. 4) Jesse Barnes
2008-07-08 14:42 ` Rafael J. Wysocki
[not found] ` <200807070334.48957.rjw@sisk.pl>
2008-07-11 20:30 ` [PATCH 6/8] PCI ACPI: Rework PCI handling of wake-up (rev. 5) Pavel Machek
[not found] ` <200807070335.27309.rjw@sisk.pl>
2008-07-11 20:31 ` [PATCH 7/8] PCI PM: Introduce pci_prepare_to_sleep and pci_back_from_sleep Pavel Machek
[not found] ` <200807070336.25004.rjw@sisk.pl>
2008-07-11 20:37 ` [PATCH 8/8] PCI: Simplify PCI device PM code (rev. 4) Pavel Machek
[not found] ` <20080711203730.GD6843@elf.ucw.cz>
2008-07-11 20:45 ` Rafael J. Wysocki
[not found] ` <200807112245.29148.rjw@sisk.pl>
2008-07-11 20:49 ` Pavel Machek
2008-07-13 20:45 ` PCI PM: Fix pci_prepare_to_sleep Rafael J. Wysocki
[not found] ` <200807132245.07414.rjw@sisk.pl>
2008-07-14 21:27 ` Jesse Barnes [this message]
2008-07-14 21:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807141427.34022.jbarnes@virtuousgeek.org \
--to=jbarnes@virtuousgeek.org \
--cc=andi@firstfloor.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
--cc=yakui.zhao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox