public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@suse.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>,
	Linux-pm mailing list <linux-pm@lists.osdl.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] hibernation should work ok with memory hotplug
Date: Wed, 29 Oct 2008 13:25:00 +0100	[thread overview]
Message-ID: <200810291325.01481.rjw@sisk.pl> (raw)
In-Reply-To: <20081029105956.GA16347@atrey.karlin.mff.cuni.cz>

On Wednesday, 29 of October 2008, Pavel Machek wrote:
> 
> hibernation + memory hotplug was disabled in kconfig because we could
> not handle hibernation + sparse mem at some point. It seems to work
> now, so I guess we can enable it.

OK, if "it seems to work now" means that it has been tested and confirmed to
work, no objection from me.

Thanks,
Rafael


> Signed-off-by: Pavel Machek <pavel@suse.cz>
> 
> 
> diff -ur linux/mm/Kconfig linux.tmp/mm/Kconfig
> --- linux/mm/Kconfig	2008-10-27 10:10:59.000000000 +0100
> +++ linux.tmp/mm/Kconfig	2008-10-29 10:02:41.000000000 +0100
> @@ -128,12 +128,9 @@
>  config MEMORY_HOTPLUG
>  	bool "Allow for memory hot-add"
>  	depends on SPARSEMEM || X86_64_ACPI_NUMA
> -	depends on HOTPLUG && !HIBERNATION && ARCH_ENABLE_MEMORY_HOTPLUG
> +	depends on HOTPLUG && ARCH_ENABLE_MEMORY_HOTPLUG
>  	depends on (IA64 || X86 || PPC64 || SUPERH || S390)
>  
> -comment "Memory hotplug is currently incompatible with Software Suspend"
> -	depends on SPARSEMEM && HOTPLUG && HIBERNATION
> -
>  config MEMORY_HOTPLUG_SPARSE
>  	def_bool y
>  	depends on SPARSEMEM && MEMORY_HOTPLUG
> 

  reply	other threads:[~2008-10-29 12:25 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 10:59 [PATCH] hibernation should work ok with memory hotplug Pavel Machek
2008-10-29 12:25 ` Rafael J. Wysocki [this message]
2008-11-03 20:51   ` Andrew Morton
2008-11-03 21:18     ` [linux-pm] " Nigel Cunningham
2008-11-03 21:21     ` Dave Hansen
2008-11-03 22:24       ` Rafael J. Wysocki
2008-11-03 22:34         ` Dave Hansen
2008-11-03 23:05           ` Rafael J. Wysocki
2008-11-03 23:10             ` Dave Hansen
2008-11-04  0:29               ` Rafael J. Wysocki
2008-11-04  0:52                 ` Dave Hansen
2008-11-03 23:39           ` Andy Whitcroft
2008-11-04  4:02           ` [linux-pm] " Nigel Cunningham
2008-11-04  7:08             ` Rafael J. Wysocki
2008-11-04  7:36               ` Dave Hansen
2008-11-04  8:54                 ` Rafael J. Wysocki
2008-11-04 15:21                   ` Dave Hansen
2008-11-04 15:35                     ` Rafael J. Wysocki
2008-11-04 15:39                       ` Dave Hansen
2008-11-04 16:34                         ` Rafael J. Wysocki
2008-11-04 16:59                           ` Dave Hansen
2008-11-05  0:38                             ` KAMEZAWA Hiroyuki
2008-11-05 11:08                               ` Rafael J. Wysocki
2008-11-06  0:14                                 ` KAMEZAWA Hiroyuki
2008-11-06  0:28                                   ` Dave Hansen
2008-11-06  0:53                                     ` KAMEZAWA Hiroyuki
2008-11-06  2:03                                       ` Nigel Cunningham
2008-11-06  2:13                                         ` KAMEZAWA Hiroyuki
2008-11-06 14:47                                       ` Alan Stern
2008-11-07  1:09                                         ` KAMEZAWA Hiroyuki
2008-11-06  8:47                                     ` Pavel Machek
2008-11-06  1:17                                   ` KAMEZAWA Hiroyuki
2008-11-06  1:43                                     ` Nigel Cunningham
2008-11-06  1:54                                       ` KAMEZAWA Hiroyuki
2008-11-06  1:59                                         ` KAMEZAWA Hiroyuki
2008-11-06  2:00                                         ` Nigel Cunningham
2008-11-06  2:07                                           ` KAMEZAWA Hiroyuki
2008-11-06  3:12                                             ` KAMEZAWA Hiroyuki
2008-11-06  3:28                                               ` Yasunori Goto
2008-11-06  6:04                                                 ` KAMEZAWA Hiroyuki
2008-11-06 14:48                                           ` Alan Stern
2008-11-06 20:46                                             ` Nigel Cunningham
2008-11-06  9:12                                     ` Pavel Machek
2008-11-06  9:12                                       ` KAMEZAWA Hiroyuki
2008-11-06  9:26                                         ` Nigel Cunningham
2008-11-06 14:43                                   ` Alan Stern
2008-11-04  7:09             ` Dave Hansen
2008-11-04  7:30               ` Nigel Cunningham
2008-11-04  7:53                 ` Dave Hansen
2008-11-05  9:10                   ` Nigel Cunningham
2008-11-05 10:58                     ` Rafael J. Wysocki
2008-11-05 16:23                     ` Dave Hansen
2008-11-06 12:28     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200810291325.01481.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.osdl.org \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox