Re: [PATCH 07/13] PM: wakelock: Add /sys/power/request_state

Pavel Machek
2009-02-05T09:27:11Z

On Thu 2009-02-05 01:25:03, Arve Hj?nnev?g wrote:
> On Thu, Feb 5, 2009 at 12:52 AM, Pavel Machek <pavel@ucw.cz> wrote:
> >> static const char * const pm_states[PM_SUSPEND_MAX] = {
> >> +#ifdef CONFIG_WAKELOCK
> >> + [PM_SUSPEND_ON] = "on",
> >> +#endif
> >> [PM_SUSPEND_STANDBY] = "standby",
> >> [PM_SUSPEND_MEM] = "mem",
> >> };
> >
> > By doing this you change /sys/power/state interface. I do not think
> > you want to do that.
>
> As long as valid_state(PM_SUSPEND_ON) returns 0, /sys/power/state
> should be unaffected.
> However, I can hardcode the "on" state in request_state if you prefer.

As long as /sys/power/state is unaffected, I'm okay with this.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html