Re: [PATCH 10/13] PM: earlysuspend: Add console switch when user requested sleep state changes.

Arve Hjønnevåg
2009-02-08T22:53:33Z

On Sun, Feb 8, 2009 at 2:02 PM, Pavel Machek <pavel@ucw.cz> wrote:
> On Thu 2009-02-05 18:29:30, Arve Hj?nnev?g wrote:
>> On Thu, Feb 5, 2009 at 1:03 AM, Pavel Machek <pavel@ucw.cz> wrote:
>> > changelog would be welcome.
>> PM: earlysuspend: Add console switch when user requested sleep
>> state changes.
>>
>> When early-suspend is enabled, the framebuffer is turned off at
>> early-suspend. If CONSOLE_EARLYSUSPEND is enabled, a console switch
>> is used to notify user space that it should stop drawing before
>> the framebuffer is disabled, and that it should repaint and resume
>> drawing after the framebuffer is turned back on.
>
> I'd say that userspace can just do the switch itself?

The purpose of the console switch is to take the framebuffer away from
user-space. Are you suggesting that we instead should initiate sleep
when user-space switches to the sleep console?

> I mean, blanking
> is slow&uncommon operation... and behaviour of kernel should not
> depend on CONFIG_ options.

The kernel does a console switch now. This just changes when it happens.

--
Arve Hjønnevåg