Re: [PATCH 03/13] PM: Implement wakelock api.

mark gross
2009-02-09T18:00:50Z

On Fri, Feb 06, 2009 at 04:47:59PM -0800, Arve Hjønnevåg wrote:
> On Fri, Feb 6, 2009 at 4:33 PM, mark gross <mgross@linux.intel.com> wrote:
> >> >> +#ifdef CONFIG_WAKELOCK_STAT
> >> >> + create_proc_read_entry("wakelocks", S_IRUGO, NULL,
> >> >> + wakelocks_read_proc, NULL);
> >> >
> >> > Shouldn't we *not* be using /proc? I think this should be under sysfs.
> >>
> >> It is not allowed under sysfs. Debugfs has been suggested, but we
> >> don't have debugfs mounted, and we include the wakelock stats in debug
> >> reports.
> >>
> >
> > why not under sysfs?
>
> The rules for sysfs state that there should be one value or an array
> of values per file.
>

Have you considered creating a misc device in /dev instead?

--mgross