From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH 09/10] Input: Hold wake lock while event queue is not empty. Date: Fri, 13 Feb 2009 00:57:04 +0000 Message-ID: <20090213005704.GA8721@srcf.ucam.org> References: <1234316955-31304-7-git-send-email-arve@android.com> <1234316955-31304-8-git-send-email-arve@android.com> <1234316955-31304-9-git-send-email-arve@android.com> <1234316955-31304-10-git-send-email-arve@android.com> <20090212113126.GC28176@srcf.ucam.org> <20090213003402.GA8393@srcf.ucam.org> <20090213004054.GB8454@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Arve =?iso-8859-1?B?SGr4bm5lduVn?= Cc: swetland@google.com, linux-pm@lists.linux-foundation.org, u.luckas@road.de, ncunningham@crca.org.au List-Id: linux-pm@vger.kernel.org On Thu, Feb 12, 2009 at 04:52:22PM -0800, Arve Hj=F8nnev=E5g wrote: > That was not the bug. Another component opened one of the input > devices, but did not read events from it. It's not the job of the kernel to guard against userspace doing foolish = things. Either you want to wait for input events to be consumed before = suspend or you don't - arbitrary timeouts provide no guarantees about = the correctness of your platform's behaviour. The default permissions on = the event devices mean that the only components that could interfere = with this are ones under your control, so fixing them seems like the = sensible approach. -- = Matthew Garrett | mjg59@srcf.ucam.org