Re: [PATCH 1/10] PM: Rework handling of interrupts during suspend-resume (rev. 5)

Thomas Gleixner
2009-03-11T22:25:12Z

On Wed, 11 Mar 2009, Linus Torvalds wrote:
> On Wed, 11 Mar 2009, Thomas Gleixner wrote:
> >
> > I'm not worried about nested ones.
>
> Then you shouldn't be worried about IRQ_SUSPENDED at all, since that one
> increments the disabled depth count.
>
> So _all_ disable/enable_irq calls will by definition be nested inside
> IRQ_SUSPENDED.

Right, if they are in disable -> enable order.

But the stupid stray enable will be visible either by wrecking the
suspend with hard to debug failures or trigger the depth check in the
resume code. I'm burned enough by the timer failures which pop up long
after the real bug happened.

Thanks,

tglx