From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: pm list <linux-pm@lists.linux-foundation.org>
Cc: Arve@smtp1.linux-foundation.org,
Jeremy Fitzhardinge <jeremy@goop.org>,
Frans Pop <elendil@planet.nl>,
LKML <linux-kernel@vger.kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH 4/10] kexec: Change kexec jump code ordering
Date: Wed, 11 Mar 2009 10:39:01 +0100 [thread overview]
Message-ID: <200903111039.02582.rjw@sisk.pl> (raw)
In-Reply-To: <200903111030.39371.rjw@sisk.pl>
From: Rafael J. Wysocki <rjw@sisk.pl>
Change the ordering of the kexec jump code so that the nonboot CPUs
are disabled after calling device drivers' "late suspend" methods.
This change reflects the recent modifications of the power management
code that is also used by kexec jump.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
kernel/kexec.c | 19 +++++++++----------
1 file changed, 9 insertions(+), 10 deletions(-)
Index: linux-2.6/kernel/kexec.c
===================================================================
--- linux-2.6.orig/kernel/kexec.c
+++ linux-2.6/kernel/kexec.c
@@ -1450,9 +1450,6 @@ int kernel_kexec(void)
error = device_suspend(PMSG_FREEZE);
if (error)
goto Resume_console;
- error = disable_nonboot_cpus();
- if (error)
- goto Resume_devices;
device_pm_lock();
/* At this point, device_suspend() has been called,
* but *not* device_power_down(). We *must*
@@ -1463,13 +1460,15 @@ int kernel_kexec(void)
*/
error = device_power_down(PMSG_FREEZE);
if (error)
- goto Unlock_pm;
-
+ goto Resume_devices;
+ error = disable_nonboot_cpus();
+ if (error)
+ goto Enable_cpus;
local_irq_disable();
/* Suspend system devices */
error = sysdev_suspend(PMSG_FREEZE);
if (error)
- goto Power_up_devices;
+ goto Enable_irqs;
} else
#endif
{
@@ -1483,13 +1482,13 @@ int kernel_kexec(void)
#ifdef CONFIG_KEXEC_JUMP
if (kexec_image->preserve_context) {
sysdev_resume();
- Power_up_devices:
+ Enable_irqs:
local_irq_enable();
- device_power_up(PMSG_RESTORE);
- Unlock_pm:
- device_pm_unlock();
+ Enable_cpus:
enable_nonboot_cpus();
+ device_power_up(PMSG_RESTORE);
Resume_devices:
+ device_pm_unlock();
device_resume(PMSG_RESTORE);
Resume_console:
resume_console();
next prev parent reply other threads:[~2009-03-11 9:39 UTC|newest]
Thread overview: 167+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-22 17:37 [RFC][PATCH 0/2] Rework disabling of interrupts during suspend-resume Rafael J. Wysocki
2009-02-22 17:38 ` [RFC][PATCH 1/2] PM: Split up sysdev_[suspend|resume] from device_power_[down|up] Rafael J. Wysocki
2009-02-22 17:39 ` [RFC][PATCH 2/2] PM: Rework handling of interrupts during suspend-resume Rafael J. Wysocki
2009-02-22 18:13 ` [RFC][PATCH 0/2] Rework disabling " Linus Torvalds
2009-02-22 18:18 ` Ingo Molnar
[not found] ` <20090222181841.GA17895@elte.hu>
2009-02-22 18:25 ` Linus Torvalds
2009-02-22 18:35 ` Linus Torvalds
[not found] ` <200902221838.51548.rjw@sisk.pl>
2009-02-22 20:56 ` [RFC][PATCH 1/2] PM: Split up sysdev_[suspend|resume] from device_power_[down|up] Adrian Bunk
[not found] ` <20090222205654.GC4485@localhost.pp.htv.fi>
2009-02-22 21:07 ` Linus Torvalds
2009-02-22 21:12 ` Ingo Molnar
2009-02-22 22:42 ` Adrian Bunk
2009-03-05 16:54 ` Pavel Machek
2009-02-22 22:37 ` [RFC][PATCH 0/2] Rework disabling of interrupts during suspend-resume Eric W. Biederman
[not found] ` <m1skm6cd3z.fsf@fess.ebiederm.org>
2009-02-22 22:56 ` Benjamin Herrenschmidt
2009-02-22 23:02 ` Linus Torvalds
[not found] ` <200902221839.50357.rjw@sisk.pl>
2009-02-22 18:01 ` [RFC][PATCH 2/2] PM: Rework handling " Linus Torvalds
[not found] ` <alpine.LFD.2.00.0902220946070.3111@localhost.localdomain>
2009-02-22 22:42 ` Rafael J. Wysocki
[not found] ` <200902222342.08285.rjw@sisk.pl>
2009-02-22 23:48 ` Rafael J. Wysocki
[not found] ` <200902230048.33635.rjw@sisk.pl>
2009-02-23 0:05 ` Linus Torvalds
[not found] ` <alpine.LFD.2.00.0902221603440.3111@localhost.localdomain>
2009-02-23 1:23 ` Linus Torvalds
2009-02-23 3:04 ` Eric W. Biederman
2009-02-23 8:36 ` Ingo Molnar
[not found] ` <m1ab8ddfbr.fsf@fess.ebiederm.org>
2009-02-23 8:44 ` Ingo Molnar
[not found] ` <20090223084400.GB9582@elte.hu>
2009-02-23 9:22 ` Eric W. Biederman
[not found] ` <m17i3ha4nk.fsf@fess.ebiederm.org>
2009-02-23 9:44 ` Ingo Molnar
2009-02-23 10:13 ` Benjamin Herrenschmidt
[not found] ` <20090223094441.GM9582@elte.hu>
2009-02-23 10:42 ` Eric W. Biederman
[not found] ` <m1bpst77te.fsf@fess.ebiederm.org>
2009-02-23 11:03 ` Rafael J. Wysocki
2009-02-23 11:04 ` Ingo Molnar
[not found] ` <20090223110433.GA17312@elte.hu>
2009-02-23 14:45 ` Rafael J. Wysocki
[not found] ` <200902231545.26250.rjw@sisk.pl>
2009-02-23 15:06 ` Ingo Molnar
2009-02-23 21:59 ` Rafael J. Wysocki
[not found] ` <200902231203.09082.rjw@sisk.pl>
2009-02-23 15:28 ` Eric W. Biederman
[not found] ` <m18wnx41h5.fsf@fess.ebiederm.org>
2009-02-23 21:39 ` Rafael J. Wysocki
[not found] ` <200902232239.05926.rjw@sisk.pl>
2009-02-24 3:30 ` Eric W. Biederman
[not found] ` <m1iqn01ph3.fsf@fess.ebiederm.org>
2009-02-24 22:42 ` Rafael J. Wysocki
[not found] ` <200902242342.07721.rjw@sisk.pl>
2009-02-24 22:51 ` Linus Torvalds
[not found] ` <alpine.LFD.2.00.0902241449221.3111@localhost.localdomain>
2009-02-24 23:07 ` Rafael J. Wysocki
[not found] ` <200902250007.13069.rjw@sisk.pl>
2009-02-24 23:09 ` Ingo Molnar
[not found] ` <20090224230935.GA15165@elte.hu>
2009-02-24 23:29 ` Rafael J. Wysocki
[not found] ` <200902250029.16107.rjw@sisk.pl>
2009-02-25 13:23 ` Ingo Molnar
2009-02-26 1:17 ` Arve Hjønnevåg
[not found] ` <d6200be20902251717r531c022bl4c25fcb902201188@mail.gmail.com>
2009-02-26 1:27 ` Linus Torvalds
[not found] ` <alpine.LFD.2.00.0902251724220.3111@localhost.localdomain>
2009-02-26 2:13 ` Arve Hjønnevåg
[not found] ` <d6200be20902251813o3ff4a065nb0a54321e27c512d@mail.gmail.com>
2009-02-26 2:51 ` Linus Torvalds
[not found] ` <alpine.LFD.2.00.0902251848120.3111@localhost.localdomain>
2009-02-26 3:00 ` Ingo Molnar
[not found] ` <20090226030050.GA3361@elte.hu>
2009-02-26 3:31 ` Arve Hjønnevåg
[not found] ` <d6200be20902251931lf563c2aw43d5266e9677e168@mail.gmail.com>
2009-02-26 3:37 ` Linus Torvalds
2009-02-26 3:50 ` Arve Hjønnevåg
[not found] ` <d6200be20902251950l34d5968q4b553ce8305ebd4b@mail.gmail.com>
2009-02-26 3:57 ` Linus Torvalds
[not found] ` <alpine.LFD.2.00.0902251956450.3111@localhost.localdomain>
2009-02-26 4:13 ` Arve Hjønnevåg
[not found] ` <d6200be20902252013v366ce771w8a129e9f3b75927f@mail.gmail.com>
2009-02-26 4:20 ` Eric W. Biederman
[not found] ` <m1y6vtkewc.fsf@fess.ebiederm.org>
2009-02-26 4:24 ` Arve Hjønnevåg
2009-02-26 9:50 ` Rafael J. Wysocki
[not found] ` <200902261050.50531.rjw@sisk.pl>
2009-02-26 20:34 ` Arve Hjønnevåg
[not found] ` <d6200be20902261234i5a3896fo78a7f56d16a247c7@mail.gmail.com>
2009-02-26 20:57 ` Benjamin Herrenschmidt
2009-02-26 21:20 ` Arve Hjønnevåg
[not found] ` <d6200be20902261320q58a347e5s1af790e56b186c81@mail.gmail.com>
2009-02-26 21:49 ` Benjamin Herrenschmidt
2009-02-26 21:58 ` Rafael J. Wysocki
[not found] ` <200902262258.55835.rjw@sisk.pl>
2009-02-26 22:10 ` Linus Torvalds
[not found] ` <alpine.LFD.2.00.0902261404580.3111@localhost.localdomain>
2009-02-26 22:30 ` Arve Hjønnevåg
2009-02-26 22:30 ` Rafael J. Wysocki
[not found] ` <d6200be20902261430w19ea3e6fye014f8443d9ab5ca@mail.gmail.com>
2009-02-26 23:10 ` Rafael J. Wysocki
[not found] ` <200902270010.38291.rjw@sisk.pl>
2009-02-27 0:00 ` Arve Hjønnevåg
[not found] ` <d6200be20902261600t7531568ekd9a7aa9215f53263@mail.gmail.com>
2009-02-27 0:27 ` Linus Torvalds
2009-02-25 4:16 ` Eric W. Biederman
[not found] ` <m18wnvup53.fsf@fess.ebiederm.org>
2009-02-25 4:26 ` Linus Torvalds
2009-02-25 4:59 ` Eric W. Biederman
2009-02-25 15:32 ` Alan Stern
[not found] ` <20090223083645.GA9582@elte.hu>
2009-02-23 11:29 ` Rafael J. Wysocki
[not found] ` <200902231229.58743.rjw@sisk.pl>
2009-02-23 12:28 ` Ingo Molnar
2009-02-23 12:45 ` Ingo Molnar
[not found] ` <20090223122832.GB31427@elte.hu>
2009-02-23 14:48 ` Rafael J. Wysocki
2009-02-23 20:49 ` Benjamin Herrenschmidt
[not found] ` <20090223124503.GC31427@elte.hu>
2009-02-23 15:07 ` Rafael J. Wysocki
2009-02-23 15:52 ` Johannes Berg
2009-02-23 17:16 ` Ingo Molnar
[not found] ` <20090223171630.GA28651@elte.hu>
2009-02-23 17:28 ` Linus Torvalds
2009-02-23 22:11 ` Rafael J. Wysocki
2009-02-23 22:11 ` Arve Hjønnevåg
[not found] ` <d6200be20902231411s654f8b3csf1388a97f3f94ac4@mail.gmail.com>
2009-02-23 22:23 ` Rafael J. Wysocki
2009-02-23 22:44 ` Arve Hjønnevåg
2009-03-01 22:21 ` [RFC][PATCH 0/4] Rework disabling " Rafael J. Wysocki
[not found] ` <200903012321.40328.rjw@sisk.pl>
2009-03-01 22:24 ` [RFC][PATCH 1/4] PM: Rework handling of interrupts during suspend-resume (rev. 4) Rafael J. Wysocki
2009-03-01 22:25 ` [RFC][PATCH 2/4] PM: Change suspend code ordering Rafael J. Wysocki
2009-03-01 22:26 ` [RFC][PATCH 3/4] PM: Change hibernation " Rafael J. Wysocki
2009-03-01 22:27 ` [RFC][PATCH 4/4] kexec: Change kexec jump " Rafael J. Wysocki
[not found] ` <200903012325.53084.rjw@sisk.pl>
2009-03-02 20:48 ` [RFC][PATCH 2/4] PM: Change suspend " Linus Torvalds
2009-03-02 22:02 ` Rafael J. Wysocki
[not found] ` <200903012324.39327.rjw@sisk.pl>
2009-03-02 23:01 ` [RFC][PATCH 1/4] PM: Rework handling of interrupts during suspend-resume (rev. 4) Arve Hjønnevåg
[not found] ` <d6200be20903021501x4ad710fbr834b11b8a6647d2c@mail.gmail.com>
2009-03-02 23:13 ` Rafael J. Wysocki
[not found] ` <200903030013.02805.rjw@sisk.pl>
2009-03-02 23:18 ` Arve Hjønnevåg
[not found] ` <d6200be20903021518r48fe6fb2vd07e9dedc4f5ff44@mail.gmail.com>
2009-03-02 23:27 ` Rafael J. Wysocki
2009-03-02 23:32 ` Linus Torvalds
2009-03-02 23:35 ` Linus Torvalds
2009-03-03 0:08 ` Arve Hjønnevåg
[not found] ` <d6200be20903021608x3ccd8d47u613b35f2ebc609be@mail.gmail.com>
2009-03-03 8:41 ` Arve Hjønnevåg
[not found] ` <200903030027.13884.rjw@sisk.pl>
2009-03-03 22:56 ` Arve Hjønnevåg
[not found] ` <d6200be20903031456r7caa3c42qa7c31dc74768449c@mail.gmail.com>
2009-03-04 22:03 ` [Update, rev. 5] " Rafael J. Wysocki
[not found] ` <200903042303.30357.rjw@sisk.pl>
2009-03-05 10:35 ` Ingo Molnar
2009-03-05 23:44 ` [RFC][PATCH 0/4] Rework disabling of interrupts during suspend-resume Linus Torvalds
2009-03-06 6:47 ` Sitsofe Wheeler
2009-03-06 10:19 ` Rafael J. Wysocki
2009-03-07 10:19 ` [RFC][PATCH][0/8] PM: Rework suspend-resume ordering to avoid problems with shared interrupts Rafael J. Wysocki
[not found] ` <200903071119.16651.rjw@sisk.pl>
2009-03-07 10:20 ` [RFC][PATCH][1/8] PM: Rework handling of interrupts during suspend-resume (rev. 5) Rafael J. Wysocki
2009-03-07 16:51 ` Alan Stern
2009-03-07 10:21 ` [RFC][PATCH][2/8] PM: Change suspend code ordering Rafael J. Wysocki
2009-03-07 10:22 ` [RFC][PATCH][3/8] PM: Change hibernation " Rafael J. Wysocki
2009-03-07 10:23 ` [RFC][PATCH][4/8] kexec: Change kexec jump " Rafael J. Wysocki
2009-03-07 10:24 ` [RFC][PATCH][5/8] PCI PM: Consistently use variable name "error" for pm call return values Rafael J. Wysocki
2009-03-07 10:25 ` [RFC][PATCH][6/8] PCI PM: Use pci_set_power_state during early resume Rafael J. Wysocki
2009-03-07 10:26 ` [RFC][PATCH][7/8] PCI PM: Move pci_restore_standard_config to pci-driver.c Rafael J. Wysocki
2009-03-07 10:27 ` [RFC][PATCH][8/8] PCI PM: Put devices into low power states during late suspend Rafael J. Wysocki
2009-03-08 19:28 ` [RFC][PATCH][0/8] PM: Rework suspend-resume ordering to avoid problems with shared interrupts Frans Pop
[not found] ` <200903082028.03720.elendil@planet.nl>
2009-03-08 20:50 ` Rafael J. Wysocki
[not found] ` <200903082150.55377.rjw@sisk.pl>
2009-03-14 8:44 ` Frans Pop
[not found] ` <200903140944.37081.elendil@planet.nl>
2009-03-14 11:59 ` Rafael J. Wysocki
[not found] ` <200903141259.02164.rjw@sisk.pl>
2009-03-14 14:11 ` Frans Pop
[not found] ` <200903141511.58455.elendil@planet.nl>
2009-03-14 22:31 ` Rafael J. Wysocki
2009-03-11 9:30 ` [PATCH 0/10] PM: Rework suspend-resume ordering to avoid problems with shared interrupts (updated) Rafael J. Wysocki
[not found] ` <200903111030.39371.rjw@sisk.pl>
2009-03-11 9:36 ` [PATCH 1/10] PM: Rework handling of interrupts during suspend-resume (rev. 5) Rafael J. Wysocki
2009-03-11 9:37 ` [PATCH 2/10] PM: Change suspend code ordering Rafael J. Wysocki
2009-03-11 9:38 ` [PATCH 3/10] PM: Change hibernation " Rafael J. Wysocki
2009-03-11 9:39 ` Rafael J. Wysocki [this message]
2009-03-11 9:41 ` [PATCH 5/10] PCI PM: Consistently use variable name "error" for pm call return values Rafael J. Wysocki
2009-03-11 9:42 ` [PATCH 6/10] PCI PM: Use pci_set_power_state during early resume Rafael J. Wysocki
2009-03-11 9:47 ` [PATCH 7/10] PCI PM: Move pci_restore_standard_config to pci-driver.c Rafael J. Wysocki
2009-03-11 9:48 ` [PATCH 8/10] PCI PM: Put devices into low power states during late suspend (rev. 2) Rafael J. Wysocki
2009-03-11 9:55 ` [PATCH 9/10] PCI PM: Make pci_set_power_state() handle devices with no PM support Rafael J. Wysocki
2009-03-11 9:56 ` [PATCH 10/10] PCI PM: Restore config spaces of all devices during early resume Rafael J. Wysocki
[not found] ` <200903111036.02482.rjw@sisk.pl>
2009-03-11 10:33 ` [PATCH 1/10] PM: Rework handling of interrupts during suspend-resume (rev. 5) Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0903111106450.29264@localhost.localdomain>
2009-03-11 20:59 ` Rafael J. Wysocki
2009-03-11 21:15 ` Rafael J. Wysocki
[not found] ` <200903112215.02445.rjw@sisk.pl>
2009-03-11 21:35 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0903112234530.29264@localhost.localdomain>
2009-03-11 21:50 ` Rafael J. Wysocki
[not found] ` <200903112250.10572.rjw@sisk.pl>
2009-03-11 21:53 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0903112251150.29264@localhost.localdomain>
2009-03-11 22:01 ` Linus Torvalds
2009-03-11 22:13 ` Rafael J. Wysocki
2009-03-11 22:25 ` Thomas Gleixner
2009-03-11 22:07 ` Rafael J. Wysocki
[not found] ` <200903112159.21166.rjw@sisk.pl>
2009-03-11 21:42 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0903112238280.29264@localhost.localdomain>
2009-03-11 22:01 ` Rafael J. Wysocki
2009-03-11 22:45 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0903112342440.29264@localhost.localdomain>
2009-03-12 13:36 ` Rafael J. Wysocki
[not found] ` <200903121436.21504.rjw@sisk.pl>
2009-03-12 21:43 ` [update, rev. 6] " Rafael J. Wysocki
[not found] ` <200903122243.27452.rjw@sisk.pl>
2009-03-13 0:39 ` Ingo Molnar
2009-03-13 7:15 ` Arve Hjønnevåg
2009-03-13 16:53 ` Rafael J. Wysocki
[not found] ` <20090313003950.GB19544@elte.hu>
2009-03-13 17:07 ` Rafael J. Wysocki
2009-03-13 19:55 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0903132052240.29264@localhost.localdomain>
2009-03-13 21:56 ` Rafael J. Wysocki
2009-03-14 0:04 ` Rafael J. Wysocki
[not found] ` <200903132256.51522.rjw@sisk.pl>
2009-03-14 7:31 ` Thomas Gleixner
[not found] ` <alpine.LFD.2.00.0903140829500.29264@localhost.localdomain>
2009-03-14 10:01 ` Rafael J. Wysocki
2009-03-14 11:24 ` [PATCH 0/11] PM: Rework suspend-resume ordering to avoid problems with shared interrupts (updated 2x) Rafael J. Wysocki
[not found] ` <200903141224.29591.rjw@sisk.pl>
2009-03-14 11:26 ` [PATCH 1/11] PM: Introduce functions for suspending and resuming device interrupts Rafael J. Wysocki
2009-03-14 11:27 ` [PATCH 2/11] PM: Rework handling of interrupts during suspend-resume Rafael J. Wysocki
2009-03-14 11:28 ` [PATCH 3/11] PM: Change suspend code ordering Rafael J. Wysocki
2009-03-14 11:28 ` [PATCH 4/11] PM: Change hibernation " Rafael J. Wysocki
2009-03-14 11:29 ` [PATCH 5/11] kexec: Change kexec jump " Rafael J. Wysocki
2009-03-14 11:30 ` [PATCH 6/11] PCI PM: Consistently use variable name "error" for pm call return values Rafael J. Wysocki
2009-03-14 11:31 ` [PATCH 7/11] PCI PM: Use pci_set_power_state during early resume Rafael J. Wysocki
2009-03-14 11:32 ` [PATCH 8/11] PCI PM: Move pci_restore_standard_config to pci-driver.c Rafael J. Wysocki
2009-03-14 11:32 ` [PATCH 9/11] PCI PM: Put devices into low power states during late suspend (rev. 2) Rafael J. Wysocki
2009-03-14 11:33 ` [PATCH 10/11] PCI PM: Make pci_set_power_state() handle devices with no PM support Rafael J. Wysocki
2009-03-14 11:34 ` [PATCH 11/11] PCI PM: Restore config spaces of all devices during early resume Rafael J. Wysocki
2009-03-14 11:43 ` [PATCH 0/11] PM: Rework suspend-resume ordering to avoid problems with shared interrupts (updated 2x) Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903111039.02582.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=Arve@smtp1.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=elendil@planet.nl \
--cc=jbarnes@virtuousgeek.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox