public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	David Rientjes <rientjes@google.com>,
	pm list <linux-pm@lists.linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: [RFC][PATCH 2/6] PM/Suspend: Do not shrink memory before suspend
Date: Sun, 10 May 2009 15:50:58 +0200	[thread overview]
Message-ID: <200905101550.59677.rjw@sisk.pl> (raw)
In-Reply-To: <200905101548.57557.rjw@sisk.pl>

From: Rafael J. Wysocki <rjw@sisk.pl>

Remove the shrinking of memory from the suspend-to-RAM code, where
it is not really necessary.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Acked-by: Nigel Cunningham <nigel@tuxonice.net>
Acked-by: Wu Fengguang <fengguang.wu@intel.com>
---
 kernel/power/main.c |   20 +-------------------
 mm/vmscan.c         |    4 ++--
 2 files changed, 3 insertions(+), 21 deletions(-)

Index: linux-2.6/kernel/power/main.c
===================================================================
--- linux-2.6.orig/kernel/power/main.c
+++ linux-2.6/kernel/power/main.c
@@ -188,9 +188,6 @@ static void suspend_test_finish(const ch
 
 #endif
 
-/* This is just an arbitrary number */
-#define FREE_PAGE_NUMBER (100)
-
 static struct platform_suspend_ops *suspend_ops;
 
 /**
@@ -226,7 +223,6 @@ int suspend_valid_only_mem(suspend_state
 static int suspend_prepare(void)
 {
 	int error;
-	unsigned int free_pages;
 
 	if (!suspend_ops || !suspend_ops->enter)
 		return -EPERM;
@@ -241,24 +237,10 @@ static int suspend_prepare(void)
 	if (error)
 		goto Finish;
 
-	if (suspend_freeze_processes()) {
-		error = -EAGAIN;
-		goto Thaw;
-	}
-
-	free_pages = global_page_state(NR_FREE_PAGES);
-	if (free_pages < FREE_PAGE_NUMBER) {
-		pr_debug("PM: free some memory\n");
-		shrink_all_memory(FREE_PAGE_NUMBER - free_pages);
-		if (nr_free_pages() < FREE_PAGE_NUMBER) {
-			error = -ENOMEM;
-			printk(KERN_ERR "PM: No enough memory\n");
-		}
-	}
+	error = suspend_freeze_processes();
 	if (!error)
 		return 0;
 
- Thaw:
 	suspend_thaw_processes();
 	usermodehelper_enable();
  Finish:
Index: linux-2.6/mm/vmscan.c
===================================================================
--- linux-2.6.orig/mm/vmscan.c
+++ linux-2.6/mm/vmscan.c
@@ -2054,7 +2054,7 @@ unsigned long global_lru_pages(void)
 		+ global_page_state(NR_INACTIVE_FILE);
 }
 
-#ifdef CONFIG_PM
+#ifdef CONFIG_HIBERNATION
 /*
  * Helper function for shrink_all_memory().  Tries to reclaim 'nr_pages' pages
  * from LRU lists system-wide, for given pass and priority.
@@ -2194,7 +2194,7 @@ out:
 
 	return sc.nr_reclaimed;
 }
-#endif
+#endif /* CONFIG_HIBERNATION */
 
 /* It's optimal to keep kswapds on the same CPUs as their memory, but
    not required for correctness.  So if the last cpu in a node goes

  parent reply	other threads:[~2009-05-10 13:50 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200905070040.08561.rjw@sisk.pl>
2009-05-06 22:41 ` [RFC][PATCH 1/5] PM/Freezer: Disable OOM killer when tasks are frozen Rafael J. Wysocki
2009-05-06 22:42 ` [RFC][PATCH 2/5] PM/Suspend: Do not shrink memory before suspend Rafael J. Wysocki
2009-05-06 22:42 ` [RFC][PATCH 3/5] PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2) Rafael J. Wysocki
2009-05-06 22:44 ` [RFC][PATCH 4/5] PM/Hibernate: Rework shrinking of memory Rafael J. Wysocki
2009-05-06 22:48 ` [RFC][PATCH 5/5] PM/Hibernate: Do not release preallocated memory unnecessarily Rafael J. Wysocki
     [not found] ` <200905070042.01880.rjw@sisk.pl>
2009-05-06 23:01   ` [RFC][PATCH 2/5] PM/Suspend: Do not shrink memory before suspend Nigel Cunningham
     [not found] ` <200905070044.13857.rjw@sisk.pl>
2009-05-06 23:27   ` [RFC][PATCH 4/5] PM/Hibernate: Rework shrinking of memory Nigel Cunningham
     [not found]   ` <1241652436.19600.176.camel@nigel-laptop>
2009-05-07 12:18     ` Rafael J. Wysocki
     [not found]     ` <200905071418.05035.rjw@sisk.pl>
2009-05-07 20:00       ` Rafael J. Wysocki
2009-05-07 20:51       ` Nigel Cunningham
     [not found]       ` <200905072200.30777.rjw@sisk.pl>
2009-05-07 20:53         ` Nigel Cunningham
     [not found] ` <200905070041.04787.rjw@sisk.pl>
2009-05-06 23:00   ` [RFC][PATCH 1/5] PM/Freezer: Disable OOM killer when tasks are frozen Nigel Cunningham
2009-05-07  0:36   ` [RFC][PATCH 1/5] PM/Freezer: Disable OOM killer whentasks " Matt Helsley
     [not found]   ` <20090507003603.GD17680@us.ibm.com>
2009-05-07 12:09     ` Rafael J. Wysocki
     [not found]   ` <1241650843.19600.124.camel@nigel-laptop>
2009-05-07 12:10     ` [RFC][PATCH 1/5] PM/Freezer: Disable OOM killer when tasks " Rafael J. Wysocki
2009-05-07 21:48 ` [RFC][PATCH 0/5] PM/Hibernate: Rework memory shrinking (rev. 2) Rafael J. Wysocki
     [not found] ` <200905072348.59856.rjw@sisk.pl>
2009-05-07 21:50   ` [RFC][PATCH 1/5] mm: Introduce __GFP_NO_OOM_KILL Rafael J. Wysocki
2009-05-07 21:51   ` [RFC][PATCH 2/5] PM/Suspend: Do not shrink memory before suspend Rafael J. Wysocki
2009-05-07 21:51   ` [RFC][PATCH 3/5] PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2) Rafael J. Wysocki
2009-05-07 21:53   ` [RFC][PATCH 4/5] PM/Hibernate: Rework shrinking of memory Rafael J. Wysocki
2009-05-07 21:55   ` [RFC][PATCH 5/5] PM/Hibernate: Do not release preallocated memory unnecessarily Rafael J. Wysocki
     [not found]   ` <200905072350.07105.rjw@sisk.pl>
2009-05-07 22:24     ` [RFC][PATCH] PM/Freezer: Disable OOM killer when tasks are frozen (was: Re: [RFC][PATCH 1/5] mm: Introduce __GFP_NO_OOM_KILL) Rafael J. Wysocki
     [not found]   ` <200905072351.11639.rjw@sisk.pl>
2009-05-08  8:52     ` [RFC][PATCH 2/5] PM/Suspend: Do not shrink memory before suspend Wu Fengguang
     [not found]   ` <200905072351.57381.rjw@sisk.pl>
2009-05-08  8:53     ` [RFC][PATCH 3/5] PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2) Wu Fengguang
2009-05-10 13:48   ` [RFC][PATCH 0/6] PM/Hibernate: Rework memory shrinking (rev. 3) Rafael J. Wysocki
     [not found]   ` <200905101548.57557.rjw@sisk.pl>
2009-05-10 13:50     ` [RFC][PATCH 1/6] mm: Introduce __GFP_NO_OOM_KILL Rafael J. Wysocki
2009-05-10 13:50     ` Rafael J. Wysocki [this message]
2009-05-10 13:51     ` [RFC][PATCH 3/6] PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2) Rafael J. Wysocki
2009-05-10 13:53     ` [RFC][PATCH 4/6] PM/Hibernate: Rework shrinking of memory Rafael J. Wysocki
2009-05-10 13:57     ` [RFC][PATCH 5/6] PM/Hibernate: Do not release preallocated memory unnecessarily Rafael J. Wysocki
2009-05-10 14:12     ` [RFC][PATCH 6/6] PM/Hibernate: Estimate hard core working set size Rafael J. Wysocki
     [not found]     ` <200905101557.48624.rjw@sisk.pl>
2009-05-10 19:49       ` [RFC][PATCH 5/6] PM/Hibernate: Do not release preallocated memory unnecessarily Rafael J. Wysocki
     [not found]     ` <200905101612.24764.rjw@sisk.pl>
2009-05-10 19:53       ` [RFC][PATCH 6/6] PM/Hibernate: Estimate hard core working set size Rafael J. Wysocki
     [not found]     ` <200905101550.09671.rjw@sisk.pl>
2009-05-11 20:12       ` [RFC][PATCH 1/6] mm: Introduce __GFP_NO_OOM_KILL David Rientjes
     [not found]       ` <alpine.DEB.2.00.0905111312140.27577@chino.kir.corp.google.com>
2009-05-11 22:14         ` Rafael J. Wysocki
     [not found]         ` <200905120014.24751.rjw@sisk.pl>
2009-05-11 22:33           ` Andrew Morton
     [not found]           ` <20090511153323.518c146a.akpm@linux-foundation.org>
2009-05-11 23:04             ` Rafael J. Wysocki
2009-05-13  8:32     ` [RFC][PATCH 0/6] PM/Hibernate: Rework memory shrinking (rev. 4) Rafael J. Wysocki
     [not found]     ` <200905131032.53624.rjw@sisk.pl>
2009-05-13  8:34       ` [PATCH 1/6] PM/Suspend: Do not shrink memory before suspend Rafael J. Wysocki
2009-05-13  8:35       ` [PATCH 2/6] PM/Hibernate: Move memory shrinking to snapshot.c (rev. 2) Rafael J. Wysocki
2009-05-13  8:37       ` [PATCH 3/6] mm, PM/Freezer: Disable OOM killer when tasks are frozen Rafael J. Wysocki
2009-05-13  8:39       ` [PATCH 4/6] PM/Hibernate: Rework shrinking of memory Rafael J. Wysocki
2009-05-13  8:40       ` [PATCH 5/6] PM/Hibernate: Do not release preallocated memory unnecessarily (rev. 2) Rafael J. Wysocki
2009-05-13  8:42       ` [RFC][PATCH 6/6] PM/Hibernate: Do not try to allocate too much memory too hard Rafael J. Wysocki
     [not found]       ` <200905131037.50011.rjw@sisk.pl>
2009-05-13  9:19         ` [PATCH 3/6] mm, PM/Freezer: Disable OOM killer when tasks are frozen Pavel Machek
2009-05-13 22:35         ` David Rientjes
     [not found]         ` <alpine.DEB.2.00.0905131534530.25680@chino.kir.corp.google.com>
2009-05-13 22:47           ` Andrew Morton
     [not found]           ` <20090513154726.0786a27d.akpm@linux-foundation.org>
2009-05-13 23:01             ` David Rientjes
     [not found]       ` <200905131039.26778.rjw@sisk.pl>
2009-05-13 19:34         ` [PATCH 4/6] PM/Hibernate: Rework shrinking of memory Andrew Morton
     [not found]         ` <20090513123409.302f4307.akpm@linux-foundation.org>
2009-05-13 20:55           ` Rafael J. Wysocki
     [not found]           ` <200905132255.04681.rjw@sisk.pl>
2009-05-13 21:16             ` Andrew Morton
     [not found]             ` <20090513141647.076b67f0.akpm@linux-foundation.org>
2009-05-13 21:56               ` Rafael J. Wysocki
     [not found]               ` <200905132356.39481.rjw@sisk.pl>
2009-05-14  9:40                 ` Pavel Machek
     [not found]                 ` <20090514094046.GF6417@elf.ucw.cz>
2009-05-14 17:49                   ` Rafael J. Wysocki
     [not found]                   ` <200905141949.53108.rjw@sisk.pl>
2009-05-15 13:09                     ` Pavel Machek
2009-05-14 18:26             ` Rafael J. Wysocki
     [not found]       ` <200905131040.37831.rjw@sisk.pl>
2009-05-14 11:09         ` [PATCH 5/6] PM/Hibernate: Do not release preallocated memory unnecessarily (rev. 2) Pavel Machek
     [not found]         ` <20090514110958.GA8871@elf.ucw.cz>
2009-05-14 17:52           ` Rafael J. Wysocki
     [not found]           ` <200905141952.21267.rjw@sisk.pl>
2009-05-15 13:11             ` Pavel Machek
     [not found]             ` <20090515131115.GC1976@elf.ucw.cz>
2009-05-15 14:52               ` Rafael J. Wysocki
     [not found]       ` <200905131042.18137.rjw@sisk.pl>
2009-05-14 11:14         ` [RFC][PATCH 6/6] PM/Hibernate: Do not try to allocate too much memory too hard Pavel Machek
     [not found]         ` <20090514111413.GB8871@elf.ucw.cz>
2009-05-14 17:59           ` Rafael J. Wysocki
     [not found]           ` <200905141959.53810.rjw@sisk.pl>
2009-05-15 13:14             ` Pavel Machek
     [not found]             ` <20090515131421.GD1976@elf.ucw.cz>
2009-05-15 14:40               ` Rafael J. Wysocki
2009-05-17 12:06         ` Wu Fengguang
     [not found]         ` <20090517120613.GB3254@localhost>
2009-05-17 12:55           ` Rafael J. Wysocki
     [not found]           ` <200905171455.06120.rjw@sisk.pl>
2009-05-17 14:07             ` Wu Fengguang
     [not found]             ` <20090517140712.GE3254@localhost>
2009-05-17 16:53               ` Rafael J. Wysocki
2009-05-17 21:14               ` Rafael J. Wysocki
     [not found]               ` <200905171853.38028.rjw@sisk.pl>
2009-05-18  8:32                 ` Wu Fengguang
     [not found]               ` <200905172314.29850.rjw@sisk.pl>
2009-05-18  8:56                 ` Wu Fengguang
     [not found]                 ` <20090518085648.GB10033@localhost>
2009-05-18 17:07                   ` Rafael J. Wysocki
     [not found]                   ` <200905181907.42079.rjw@sisk.pl>
2009-05-19  0:47                     ` Wu Fengguang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200905101550.59677.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=akpm@linux-foundation.org \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=rientjes@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox