From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 3/9] PM: suspend_block: Abort task freezing if a suspend_blocker is active. Date: Tue, 12 May 2009 12:04:16 +0200 Message-ID: <20090512100416.GD14217@elf.ucw.cz> References: <1241583529-5092-1-git-send-email-arve@android.com> <1241583529-5092-2-git-send-email-arve@android.com> <1241583529-5092-3-git-send-email-arve@android.com> <1241583529-5092-4-git-send-email-arve@android.com> <20090505195753.GE1379@ucw.cz> <20090507104143.GB6132@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Arve Hj?nnev?g Cc: ncunningham@crca.org.au, u.luckas@road.de, swetland@google.com, linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org Hi! > > IOW the patch should not be needed when the bugs are fixed. You should > > not need it now. > > > > Can you drop it for now (or keep it in private tree or something). If > > you have scenario where it takes significant time and that can't be > > fixed, please present the scenario and we can reconsider it. > > > > It can take a significant amount of time. It has to wait for every > thread it signalled to freeze which seems to be every user-space > thread. On my device, with 200 threads, this took less than 10ms half > the time, up to 460ms in the worst case. Ok, 460ms in the worst case is good reason to apply this patch, I agree. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html