From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] pm: remove unused asm/suspend.h Date: Wed, 13 May 2009 15:24:05 +0200 Message-ID: <200905131524.06055.rjw@sisk.pl> References: <20090512131606.7984.69575.sendpatchset@rx1.opensource.se> <20090512193200.GA22728@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Magnus Damm Cc: linux-pm@lists.linux-foundation.org, akpm@linux-foundation.org List-Id: linux-pm@vger.kernel.org On Wednesday 13 May 2009, Magnus Damm wrote: > Hi Pavel, > > On Wed, May 13, 2009 at 4:32 AM, Pavel Machek wrote: > > On Tue 2009-05-12 22:16:06, Magnus Damm wrote: > >> > >> From: Magnus Damm > >> > >> This patch removes unused asm/suspend.h files for > >> the following architectures: > >> > >> alpha, arm, ia64, m68k, mips, s390, um > >> > >> Signed-off-by: Magnus Damm > > > > Are you sure? arm does support suspend... > > Not sure, but these days is only included from > kernel/power/disk.c. And that file is only built if CONFIG_HIBERNATION > is set. I've grepped for arch_prepare_suspend and > ARCH_HIBERNATION_POSSIBLE but I don't get any matches under > arch/arm... > > Or am I misunderstanding? =) Sounds reasonable, but have you actually tested compilation on the architectures you're changing? Rafael