From: Pavel Machek <pavel@ucw.cz>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-pm@lists.linux-foundation.org, akpm@linux-foundation.org
Subject: Re: [PATCH] pm: remove unused asm/suspend.h
Date: Thu, 14 May 2009 11:31:47 +0200 [thread overview]
Message-ID: <20090514093147.GE6417@elf.ucw.cz> (raw)
In-Reply-To: <aec7e5c30905130304r38796bf4if741f53435bb5cb3@mail.gmail.com>
On Wed 2009-05-13 19:04:14, Magnus Damm wrote:
> Hi Pavel,
>
> On Wed, May 13, 2009 at 4:32 AM, Pavel Machek <pavel@ucw.cz> wrote:
> > On Tue 2009-05-12 22:16:06, Magnus Damm wrote:
> >>
> >> From: Magnus Damm <damm@igel.co.jp>
> >>
> >> This patch removes unused asm/suspend.h files for
> >> the following architectures:
> >>
> >> alpha, arm, ia64, m68k, mips, s390, um
> >>
> >> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> >
> > Are you sure? arm does support suspend...
>
> Not sure, but these days <asm/suspend.h> is only included from
> kernel/power/disk.c. And that file is only built if CONFIG_HIBERNATION
> is set. I've grepped for arch_prepare_suspend and
> ARCH_HIBERNATION_POSSIBLE but I don't get any matches under
> arch/arm...
>
> Or am I misunderstanding? =)
I did rm arch/arm/include/asm/suspend.h and ran test compile on
zaurus; it seems ok. Because no other architectures are close to
supporting suspend/hibernation, I think I can
Acked-by: Pavel Machek <pavel@ucw.cz>
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-05-14 9:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-12 13:16 [PATCH] pm: remove unused asm/suspend.h Magnus Damm
2009-05-12 19:32 ` Pavel Machek
2009-05-13 10:04 ` Magnus Damm
2009-05-13 13:24 ` Rafael J. Wysocki
2009-05-14 3:09 ` Magnus Damm
2009-05-14 17:45 ` Rafael J. Wysocki
2009-05-14 9:31 ` Pavel Machek [this message]
2009-05-14 23:11 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090514093147.GE6417@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@linux-foundation.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox