Re: [PATCH] pm: remove unused asm/suspend.h

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Thursday 14 May 2009, Magnus Damm wrote:
> On Wed, May 13, 2009 at 10:24 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> > On Wednesday 13 May 2009, Magnus Damm wrote:
> >> On Wed, May 13, 2009 at 4:32 AM, Pavel Machek <pavel@ucw.cz> wrote:
> >> > On Tue 2009-05-12 22:16:06, Magnus Damm wrote:
> >> >>
> >> >> From: Magnus Damm <damm@igel.co.jp>
> >> >>
> >> >> This patch removes unused asm/suspend.h files for
> >> >> the following architectures:
> >> >>
> >> >>  alpha, arm, ia64, m68k, mips, s390, um
> >> >>
> >> >> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> >> >
> >> > Are you sure? arm does support suspend...
> >>
> >> Not sure, but these days <asm/suspend.h> is only included from
> >> kernel/power/disk.c. And that file is only built if CONFIG_HIBERNATION
> >> is set. I've grepped for arch_prepare_suspend and
> >> ARCH_HIBERNATION_POSSIBLE but I don't get any matches under
> >> arch/arm...
> >>
> >> Or am I misunderstanding? =)
> >
> > Sounds reasonable, but have you actually tested compilation on the
> > architectures you're changing?
> 
> No, I have not. However, grepping shows that it's pretty safe:
> 
> $ find . | xargs grep asm/suspend
> 
> (files in arch/powerpc, arch/x86, arch/sh and kernel/power/disk.c)
> 
> Basically, the patch is doing further cleanups on top of:
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a8af78982ff4c0b3731527b0217d286a343a3089
> 
> Since that patch is included upstream already it is safe to assume
> that <asm/suspend.h> is only needed by architectures setting
> ARCH_HIBERNATION_POSSIBLE. Which means powerpc, x86 and sh. The rest
> of the header files can go away.
> 
> Still want me to compile test for all architectures affected?

No, thanks.

Best,
Rafael