Re: [PATCH] pm: remove unused asm/suspend.h

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Thursday 14 May 2009, Pavel Machek wrote:
> On Wed 2009-05-13 19:04:14, Magnus Damm wrote:
> > Hi Pavel,
> > 
> > On Wed, May 13, 2009 at 4:32 AM, Pavel Machek <pavel@ucw.cz> wrote:
> > > On Tue 2009-05-12 22:16:06, Magnus Damm wrote:
> > >>
> > >> From: Magnus Damm <damm@igel.co.jp>
> > >>
> > >> This patch removes unused asm/suspend.h files for
> > >> the following architectures:
> > >>
> > >>  alpha, arm, ia64, m68k, mips, s390, um
> > >>
> > >> Signed-off-by: Magnus Damm <damm@igel.co.jp>
> > >
> > > Are you sure? arm does support suspend...
> > 
> > Not sure, but these days <asm/suspend.h> is only included from
> > kernel/power/disk.c. And that file is only built if CONFIG_HIBERNATION
> > is set. I've grepped for arch_prepare_suspend and
> > ARCH_HIBERNATION_POSSIBLE but I don't get any matches under
> > arch/arm...
> > 
> > Or am I misunderstanding? =)
> 
> I did rm arch/arm/include/asm/suspend.h and ran test compile on
> zaurus; it seems ok. Because no other architectures are close to
> supporting suspend/hibernation, I think I can
> 
> Acked-by: Pavel Machek <pavel@ucw.cz>

Applied to the suspend tree.

Thanks,
Rafael