From: Bjorn Helgaas <bjorn.helgaas@hp.com>
To: Rafael J Wysocki <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>,
Len Brown <lenb@kernel.org>
Cc: linux-pm@lists.linux-foundation.org
Subject: [PATCH] PM: check sysdev_suspend(PMSG_FREEZE) return value
Date: Fri, 15 May 2009 05:33:49 -0600 [thread overview]
Message-ID: <20090515113349.3659.20040.stgit@bob.kio> (raw)
Check the return value of sysdev_suspend(). I think this was a typo.
Without this change, the following "if" check is always false.
I also changed the error message so it's distinguishable from the
similar message a few lines above.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
---
kernel/power/disk.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/power/disk.c b/kernel/power/disk.c
index 2616832..6674722 100644
--- a/kernel/power/disk.c
+++ b/kernel/power/disk.c
@@ -242,9 +242,9 @@ static int create_image(int platform_mode)
local_irq_disable();
- sysdev_suspend(PMSG_FREEZE);
+ error = sysdev_suspend(PMSG_FREEZE);
if (error) {
- printk(KERN_ERR "PM: Some devices failed to power down, "
+ printk(KERN_ERR "PM: Some system devices failed to power down, "
"aborting hibernation\n");
goto Enable_irqs;
}
next reply other threads:[~2009-05-15 11:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 11:33 Bjorn Helgaas [this message]
2009-05-15 21:00 ` [PATCH] PM: check sysdev_suspend(PMSG_FREEZE) return value Pavel Machek
2009-05-15 21:07 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515113349.3659.20040.stgit@bob.kio \
--to=bjorn.helgaas@hp.com \
--cc=lenb@kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox