From: Magnus Damm <magnus.damm@gmail.com>
To: linux-pm@lists.linux-foundation.org
Cc: akpm@linux-foundation.org
Subject: [PATCH][RFC] pm: remove bus_type suspend_late()/resume_early()
Date: Fri, 15 May 2009 23:14:04 +0900 [thread overview]
Message-ID: <20090515141404.9189.51590.sendpatchset@rx1.opensource.se> (raw)
From: Magnus Damm <damm@igel.co.jp>
Remove the ->suspend_late() and ->resume_early() callbacks
from struct bus_type. These callbacks are legacy stuff at
this point and since there seem to be no in-tree users we
may as well remove them. New users should use dev_pm_ops.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
This patch is almost too good to be true so there must be
something wrong. I did however spend quite some time grepping
and I could not find any in-tree users.
drivers/base/power/main.c | 7 -------
include/linux/device.h | 2 --
2 files changed, 9 deletions(-)
--- 0001/include/linux/device.h
+++ work/include/linux/device.h 2009-05-15 13:11:46.000000000 +0900
@@ -62,8 +62,6 @@ struct bus_type {
void (*shutdown)(struct device *dev);
int (*suspend)(struct device *dev, pm_message_t state);
- int (*suspend_late)(struct device *dev, pm_message_t state);
- int (*resume_early)(struct device *dev);
int (*resume)(struct device *dev);
struct dev_pm_ops *pm;
--- 0001/drivers/base/power/main.c
+++ work/drivers/base/power/main.c 2009-05-15 13:15:29.000000000 +0900
@@ -334,9 +334,6 @@ static int resume_device_noirq(struct de
if (dev->bus->pm) {
pm_dev_dbg(dev, state, "EARLY ");
error = pm_noirq_op(dev, dev->bus->pm, state);
- } else if (dev->bus->resume_early) {
- pm_dev_dbg(dev, state, "legacy EARLY ");
- error = dev->bus->resume_early(dev);
}
End:
TRACE_RESUME(error);
@@ -591,10 +588,6 @@ static int suspend_device_noirq(struct d
if (dev->bus->pm) {
pm_dev_dbg(dev, state, "LATE ");
error = pm_noirq_op(dev, dev->bus->pm, state);
- } else if (dev->bus->suspend_late) {
- pm_dev_dbg(dev, state, "legacy LATE ");
- error = dev->bus->suspend_late(dev, state);
- suspend_report_result(dev->bus->suspend_late, error);
}
return error;
}
next reply other threads:[~2009-05-15 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-15 14:14 Magnus Damm [this message]
2009-05-15 14:29 ` [PATCH][RFC] pm: remove bus_type suspend_late()/resume_early() Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090515141404.9189.51590.sendpatchset@rx1.opensource.se \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox