Re: Suspend problems in 2.6.31-rc6

Jesse Barnes
2009-08-20T16:05:48Z

On Thu, 20 Aug 2009 17:41:06 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Wednesday 19 August 2009, Rafael J. Wysocki wrote:
> > On Wednesday 19 August 2009, Alan Stern wrote:
> > > On Wed, 19 Aug 2009, Rafael J. Wysocki wrote:
> > >
> > > > > Commenting out the second call to pci_restore_state()
> > > > > apparently fixes the problem. I have no idea whether it's
> > > > > the right thing to do, though.
> > > >
> > > > It is. The PCI core have restored the PCI config already
> > > > anyway at the early resume stage.
> > > >
> > > > I think the first pci_restore_state() could be dropped from
> > > > there as well.
> > >
> > > What about the other AGP drivers in drivers/char/agp? Looks like
> > > their suspend and resume routines could all use some updating.
> >
> > As well as many other drivers. :-)
> >
> > Usually, however, restoring the PCI config space twice doesn't
> > hurt, although it evidently does hurt on your system.
> >
> > Hm, there's a patch that should help here I think. Can you please
> > test this one: http://patchwork.kernel.org/patch/40062/ ?
>
> Quoting the patch for completness.
>
> ---
> From: Alek Du <alek.du@intel.com>
> Subject: [PATCH] pci: check saved state before restore

Ok, I'll send that over to Linus. I'd been holding off on it since it
didn't actually fix any external reports. But now that we have one...

--
Jesse Barnes, Intel Open Source Technology Center