Re: Suspend problems in 2.6.31-rc6

Zhenyu Wang
2009-08-24T01:30:48Z

[-- Attachment #1.1: Type: text/plain, Size: 1584 bytes --]

On 2009.08.21 10:32:22 -0400, Alan Stern wrote:
> > > Could you try with this one? And what's your gfx chip?
>
> 00:02.0 VGA compatible controller: Intel Corporation 82845G/GL[Brookdale-G]/GE Chipset Integrated Graphics Device (rev 03)
>
> I don't think this will help. The state _is_ getting saved, so saving
> it again won't make any difference. The problem occurs because the
> state is restored at the wrong time.

oh, that's old chip, it looks later chip doesn't have this problem.

>
> > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> > index fc4b68a..f54880f 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.c
> > +++ b/drivers/gpu/drm/i915/i915_drv.c
> > @@ -95,7 +95,11 @@ static int i915_resume(struct drm_device *dev)
> > int ret = 0;
> >
> > pci_set_power_state(dev->pdev, PCI_D0);
> > - pci_restore_state(dev->pdev);
> > + /* XXX as pci layer should have already early restore state
> > + for us, or intel_agp driver has taken care of reconfigure,
> > + we don't need to restore again here, which might corrupt
> > + reconfigured state...*/
> > + /* pci_restore_state(dev->pdev); */
> > if (pci_enable_device(dev->pdev))
> > return -1;
> > pci_set_master(dev->pdev);
>
> And I don't think this will help since I don't have a 915 controller.
>

This's only for other possible graphics problem involved in suspend/resume,
and drm/i915 should also work for your 845G. ;)

--
Open Source Technology Center, Intel ltd.

$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]