Re: Suspend problems in 2.6.31-rc6

Rafael J. Wysocki
2009-08-19T21:22:25Z

On Wednesday 19 August 2009, Alan Stern wrote:
> On Wed, 19 Aug 2009, Rafael J. Wysocki wrote:
>
> > > Commenting out the second call to pci_restore_state() apparently fixes
> > > the problem. I have no idea whether it's the right thing to do,
> > > though.
> >
> > It is. The PCI core have restored the PCI config already anyway at the early
> > resume stage.
> >
> > I think the first pci_restore_state() could be dropped from there as well.
>
> What about the other AGP drivers in drivers/char/agp? Looks like their
> suspend and resume routines could all use some updating.

As well as many other drivers. :-)

Usually, however, restoring the PCI config space twice doesn't hurt, although
it evidently does hurt on your system.

Hm, there's a patch that should help here I think. Can you please test
this one: http://patchwork.kernel.org/patch/40062/ ?

Best,
Rafael