Re: Suspend problems in 2.6.31-rc6

Jiri Slaby
2009-08-17T21:31:48Z

On 08/17/2009 11:15 PM, Greg KH wrote:
> Oh wait, I think this is only needed on top of the rest of the tty tree,
> Linus's tree should not need this.
>
> But I think Jiri is tracking down something in this area, Jiri?

Yes, but I think it's unrelated. My problem lies probably somewhere in
kernel/cpu.c.

Anyway I use the following. The function is called with interrupts
disabled during resume. Won't it help you by a chance?

commit e5a02f5ee04b20aa84295c4912259d4fa5b7642b
Author: Jiri Slaby <jirislaby@gmail.com>
Date: Thu Aug 13 21:53:18 2009 +0200

fix load_debug_register locking

diff --git a/kernel/hw_breakpoint.c b/kernel/hw_breakpoint.c
index c1f64e6..bc5368d 100644
--- a/kernel/hw_breakpoint.c
+++ b/kernel/hw_breakpoint.c
@@ -80,17 +80,15 @@ void load_debug_registers(void)
unsigned long flags;
struct task_struct *tsk = current;

- spin_lock_bh(&hw_breakpoint_lock);
+ spin_lock_irqsave(&hw_breakpoint_lock, flags);

/* Prevent IPIs for new kernel breakpoint updates */
- local_irq_save(flags);
arch_update_kernel_hw_breakpoint(NULL);
- local_irq_restore(flags);

if (test_tsk_thread_flag(tsk, TIF_DEBUG))
arch_install_thread_hw_breakpoint(tsk);

- spin_unlock_bh(&hw_breakpoint_lock);
+ spin_unlock_irqrestore(&hw_breakpoint_lock, flags);
}

/*