Re: Suspend problems in 2.6.31-rc6

Alan Stern
2009-08-19T14:26:05Z

On Wed, 19 Aug 2009, Rafael J. Wysocki wrote:

> > Commenting out the second call to pci_restore_state() apparently fixes
> > the problem. I have no idea whether it's the right thing to do,
> > though.
>
> It is. The PCI core have restored the PCI config already anyway at the early
> resume stage.
>
> I think the first pci_restore_state() could be dropped from there as well.

What about the other AGP drivers in drivers/char/agp? Looks like their
suspend and resume routines could all use some updating.

Alan Stern