From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>, Jesse Barnes <jbarnes@virtuousgeek.org>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Dave Airlie <airlied@redhat.com>,
Linux-pm mailing list <linux-pm@lists.linux-foundation.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: Suspend problems in 2.6.31-rc6
Date: Wed, 19 Aug 2009 23:22:25 +0200 [thread overview]
Message-ID: <200908192322.25261.rjw@sisk.pl> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0908191022390.3001-100000@iolanthe.rowland.org>
On Wednesday 19 August 2009, Alan Stern wrote:
> On Wed, 19 Aug 2009, Rafael J. Wysocki wrote:
>
> > > Commenting out the second call to pci_restore_state() apparently fixes
> > > the problem. I have no idea whether it's the right thing to do,
> > > though.
> >
> > It is. The PCI core have restored the PCI config already anyway at the early
> > resume stage.
> >
> > I think the first pci_restore_state() could be dropped from there as well.
>
> What about the other AGP drivers in drivers/char/agp? Looks like their
> suspend and resume routines could all use some updating.
As well as many other drivers. :-)
Usually, however, restoring the PCI config space twice doesn't hurt, although
it evidently does hurt on your system.
Hm, there's a patch that should help here I think. Can you please test
this one: http://patchwork.kernel.org/patch/40062/ ?
Best,
Rafael
next prev parent reply other threads:[~2009-08-19 21:22 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 15:11 Suspend problems in 2.6.31-rc6 Alan Stern
2009-08-17 18:28 ` Rafael J. Wysocki
2009-08-17 20:53 ` Alan Stern
2009-08-17 21:14 ` Greg KH
2009-08-17 21:15 ` Greg KH
2009-08-17 21:31 ` Jiri Slaby
2009-08-17 21:33 ` Jiri Slaby
2009-08-17 21:21 ` Rafael J. Wysocki
2009-08-17 21:50 ` Alan Stern
2009-08-18 16:07 ` Alan Stern
2009-08-18 23:22 ` Rafael J. Wysocki
2009-08-19 2:01 ` Zhenyu Wang
2009-08-19 14:42 ` Alan Stern
2009-08-20 1:05 ` Zhenyu Wang
2009-08-20 14:03 ` Alan Stern
2009-08-21 1:17 ` Zhenyu Wang
2009-08-20 15:34 ` Rafael J. Wysocki
2009-08-19 14:26 ` Alan Stern
2009-08-19 21:22 ` Rafael J. Wysocki [this message]
2009-08-20 15:17 ` Alan Stern
2009-08-20 16:17 ` Rafael J. Wysocki
2009-08-21 1:21 ` Zhenyu Wang
2009-08-21 3:13 ` Zhenyu Wang
2009-08-21 14:32 ` Alan Stern
2009-08-21 17:01 ` Rafael J. Wysocki
2009-08-24 2:34 ` Zhenyu Wang
2009-08-24 18:55 ` Rafael J. Wysocki
2009-08-25 0:59 ` Alan Stern
2009-08-27 14:51 ` Alan Stern
2009-08-27 16:18 ` Jesse Barnes
2009-08-24 1:30 ` Zhenyu Wang
2009-08-20 15:41 ` Rafael J. Wysocki
2009-08-20 16:05 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908192322.25261.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=airlied@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=stern@rowland.harvard.edu \
--cc=zhenyuw@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox