From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: Suspend problems in 2.6.31-rc6 Date: Wed, 19 Aug 2009 23:22:25 +0200 Message-ID: <200908192322.25261.rjw@sisk.pl> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Alan Stern Cc: Greg KH , Jesse Barnes , Zhenyu Wang , Dave Airlie , Linux-pm mailing list , Alan Cox List-Id: linux-pm@vger.kernel.org On Wednesday 19 August 2009, Alan Stern wrote: > On Wed, 19 Aug 2009, Rafael J. Wysocki wrote: > > > > Commenting out the second call to pci_restore_state() apparently fixes > > > the problem. I have no idea whether it's the right thing to do, > > > though. > > > > It is. The PCI core have restored the PCI config already anyway at the early > > resume stage. > > > > I think the first pci_restore_state() could be dropped from there as well. > > What about the other AGP drivers in drivers/char/agp? Looks like their > suspend and resume routines could all use some updating. As well as many other drivers. :-) Usually, however, restoring the PCI config space twice doesn't hurt, although it evidently does hurt on your system. Hm, there's a patch that should help here I think. Can you please test this one: http://patchwork.kernel.org/patch/40062/ ? Best, Rafael