From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhenyu Wang Subject: Re: Suspend problems in 2.6.31-rc6 Date: Thu, 20 Aug 2009 09:05:28 +0800 Message-ID: <20090820010528.GA9596@zhen-devel.sh.intel.com> References: <20090819020156.GA22638@zhen-devel.sh.intel.com> Reply-To: Zhenyu Wang Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5494542548496381390==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Mime-version: 1.0 Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Alan Stern Cc: Greg KH , Jesse Barnes , Dave Airlie , Linux-pm mailing list , Alan Cox List-Id: linux-pm@vger.kernel.org --===============5494542548496381390== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="NzB8fVQJ5HfG6fxh" Content-Disposition: inline --NzB8fVQJ5HfG6fxh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2009.08.19 10:42:07 -0400, Alan Stern wrote: > On Wed, 19 Aug 2009, Zhenyu Wang wrote: >=20 > > Rafael, as I added this restore long time ago, pci core has changed in = some way? > > We had problem when reconfigure agp GTT space in resume, as we must be = sure > > gfx device's config space has been restored properly, and as 02:00 gfx = device > > restored later than host bridge 00:00 device, that came to my origin pa= tch to > > restore it earlier. >=20 > Why did you do it that way? I mean, why not restore the gfx device's=20 > config space in its own resume routine instead of in the host bridge's=20 > resume routine? >=20 That's the order issue I have mentioned. intel_agp is the pci driver for host bridge (dev 00:00), and drm/i915 is the pci driver for gfx device (dev 00:02). Host bridge will always resume earlier than gfx device, but for intel_agp we need to access gfx device when reconfigure GTT in resume, we can't wait until restore happen in i915 driver. So there might be a conflict here, as i915 driver also do pci_restore_state= () after we did reconfigure in intel_agp driver, some configs may be corrupted= =20 then. Although I haven't seen it in real testing.=20 --=20 Open Source Technology Center, Intel ltd. $gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827 --NzB8fVQJ5HfG6fxh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkqMoVgACgkQsQQaM014GCe3rACfd5v2civlM3+J1Ne3fHc3LLl2 2ncAn08/3uK0kXv5kiy04QH9215SIX8h =ZtSr -----END PGP SIGNATURE----- --NzB8fVQJ5HfG6fxh-- --===============5494542548496381390== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============5494542548496381390==--