From: Pavel Machek <pavel@ucw.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Joe Perches <joe@perches.com>, Len Brown <len.brown@intel.com>,
linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 15/21] kernel/power/: use pr_<level> and add pr_fmt(fmt)
Date: Sun, 11 Oct 2009 10:59:00 +0200 [thread overview]
Message-ID: <20091011085859.GA1337@ucw.cz> (raw)
In-Reply-To: <200910102328.37108.rjw@sisk.pl>
> > Here's the same patch redone against -next.
> >
> > Added #define pr_fmt(fmt) "PM: " fmt
> > Converted printk(KERN_<level> to pr_<level>(
> > Converted printks without KERN_ to pr_info or pr_cont
> > Removed hard coded "PM: " prefix from message strings
> > Added pr_fmt() to __initdata strings
> > Integrated multiple line strings
> > All logging messages are now output prefixed with "PM: "
>
> Does this patch depend on any other patch that haven't been merged yet?
>
> I still don't like pr_info(), pr_error() and pr_crit().
Well, rest of kernel uses them, they are shorter, and will save few
bytes too... so why not?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2009-10-11 8:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-05 0:53 [PATCH 00/21] pr_dbg, pr_fmt Joe Perches
2009-10-05 0:53 ` [PATCH 15/21] kernel/power/: use pr_<level> and add pr_fmt(fmt) Joe Perches
2009-10-05 19:43 ` Rafael J. Wysocki
2009-10-05 20:31 ` Joe Perches
2009-10-05 22:37 ` Rafael J. Wysocki
2009-10-09 3:53 ` Joe Perches
2009-10-10 21:28 ` Rafael J. Wysocki
2009-10-11 1:49 ` Joe Perches
2009-10-11 8:59 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091011085859.GA1337@ucw.cz \
--to=pavel@ucw.cz \
--cc=joe@perches.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox