resume crashes in intel_init_thermal [was: mmotm 2009-11-13-19-59 uploaded]

resume crashes in intel_init_thermal [was: mmotm 2009-11-13-19-59 uploaded]

[Jiri Slaby]

On 11/14/2009 05:03 AM, akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2009-11-13-19-59 has been uploaded to

Hi, resume from ram dies in intel_init_thermal in that kernel:
http://www.fi.muni.cz/~xslaby/sklad/mce_oops.png

The code is cc cc cc cc ... KGDB and KPROBES are off, I don't know where
the pattern may come from.

Does it ring a bell? Any ideas? mmotm 2009-11-01-10-01 was OK.

thanks,
-- 
js
Faculty of Informatics, Masaryk University
Suse Labs, Novell

Re: resume crashes in intel_init_thermal [was: mmotm 2009-11-13-19-59 uploaded]

[Andrew Morton]

On Sat, 14 Nov 2009 14:28:00 +0100 Jiri Slaby <jirislaby@gmail.com> wrote:

> On 11/14/2009 05:03 AM, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2009-11-13-19-59 has been uploaded to
> 
> Hi, resume from ram dies in intel_init_thermal in that kernel:
> http://www.fi.muni.cz/~xslaby/sklad/mce_oops.png

lol.

> The code is cc cc cc cc ... KGDB and KPROBES are off, I don't know where
> the pattern may come from.
> 
> Does it ring a bell? Any ideas? mmotm 2009-11-01-10-01 was OK.

From: Andrew Morton <akpm@linux-foundation.org>

Revert

: commit ce6b5d768c79b9d5dd6345c033bae781d5ca9b8e
: Author:     Yong Wang <yong.y.wang@linux.intel.com>
: AuthorDate: Wed Nov 11 15:51:25 2009 +0800
: Commit:     Ingo Molnar <mingo@elte.hu>
: CommitDate: Wed Nov 11 12:33:32 2009 +0100
: 
:     x86: Mark the thermal init functions __init

because intel_init_thermal() is called from mce_intel_feature_init() at
resume time, and we'd like its text to still be in memory when that
happens.

Reported-by: Jiri Slaby <jirislaby@gmail.com>
Cc: Yong Wang <yong.y.wang@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 arch/x86/kernel/cpu/mcheck/therm_throt.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff -puN arch/x86/kernel/cpu/mcheck/therm_throt.c~revert-1 arch/x86/kernel/cpu/mcheck/therm_throt.c
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c~revert-1
+++ a/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -256,7 +256,7 @@ asmlinkage void smp_thermal_interrupt(st
 	ack_APIC_irq();
 }
 
-void __init mcheck_intel_therm_init(void)
+void mcheck_intel_therm_init(void)
 {
 	/*
 	 * This function is only called on boot CPU. Save the init thermal
@@ -268,7 +268,7 @@ void __init mcheck_intel_therm_init(void
 		lvtthmr_init = apic_read(APIC_LVTTHMR);
 }
 
-void __init intel_init_thermal(struct cpuinfo_x86 *c)
+void intel_init_thermal(struct cpuinfo_x86 *c)
 {
 	unsigned int cpu = smp_processor_id();
 	int tm2 = 0;
_

Re: resume crashes in intel_init_thermal [was: mmotm 2009-11-13-19-59 uploaded]

[Jiri Slaby]

On 11/14/2009 05:15 PM, Andrew Morton wrote:
> Revert
> 
> : commit ce6b5d768c79b9d5dd6345c033bae781d5ca9b8e
> : Author:     Yong Wang <yong.y.wang@linux.intel.com>
> : AuthorDate: Wed Nov 11 15:51:25 2009 +0800
> : Commit:     Ingo Molnar <mingo@elte.hu>
> : CommitDate: Wed Nov 11 12:33:32 2009 +0100
> : 
> :     x86: Mark the thermal init functions __init
> 
> because intel_init_thermal() is called from mce_intel_feature_init() at
> resume time, and we'd like its text to still be in memory when that
> happens.

Works for me. Thanks.

-- 
js
Faculty of Informatics, Masaryk University
Suse Labs, Novell

Re: resume crashes in intel_init_thermal [was: mmotm 2009-11-13-19-59 uploaded]

[Ingo Molnar]

* Jiri Slaby <jirislaby@gmail.com> wrote:

> On 11/14/2009 05:03 AM, akpm@linux-foundation.org wrote:
> > The mm-of-the-moment snapshot 2009-11-13-19-59 has been uploaded to
> 
> Hi, resume from ram dies in intel_init_thermal in that kernel:
> http://www.fi.muni.cz/~xslaby/sklad/mce_oops.png
> 
> The code is cc cc cc cc ... KGDB and KPROBES are off, I don't know where
> the pattern may come from.
> 
> Does it ring a bell? Any ideas? mmotm 2009-11-01-10-01 was OK.

This is a known bug - see the fix below.

	Ingo

-------------->
>From cffd377e5879ea58522224a785a083f201afd80e Mon Sep 17 00:00:00 2001
From: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Date: Thu, 12 Nov 2009 15:52:40 +0900
Subject: [PATCH] x86, mce: Fix __init annotations

The intel_init_thermal() is called from resume path, so it
cannot be marked as __init.

OTOH mce_banks_init() is only called from
__mcheck_cpu_cap_init() which is marked as __cpuinit, so it can
be also marked as __cpuinit.

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Acked-by: Yong Wang <yong.y.wang@linux.intel.com>
LKML-Reference: <4AFBB0B8.2070501@jp.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/x86/kernel/cpu/mcheck/mce.c         |    4 ++--
 arch/x86/kernel/cpu/mcheck/therm_throt.c |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 0d41020..5f277ca 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1201,7 +1201,7 @@ int mce_notify_irq(void)
 }
 EXPORT_SYMBOL_GPL(mce_notify_irq);
 
-static int mce_banks_init(void)
+static int __cpuinit __mcheck_cpu_mce_banks_init(void)
 {
 	int i;
 
@@ -1242,7 +1242,7 @@ static int __cpuinit __mcheck_cpu_cap_init(void)
 	WARN_ON(banks != 0 && b != banks);
 	banks = b;
 	if (!mce_banks) {
-		int err = mce_banks_init();
+		int err = __mcheck_cpu_mce_banks_init();
 
 		if (err)
 			return err;
diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c
index 8a73d5c..4fef985 100644
--- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
+++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
@@ -268,7 +268,7 @@ void __init mcheck_intel_therm_init(void)
 		lvtthmr_init = apic_read(APIC_LVTTHMR);
 }
 
-void __init intel_init_thermal(struct cpuinfo_x86 *c)
+void intel_init_thermal(struct cpuinfo_x86 *c)
 {
 	unsigned int cpu = smp_processor_id();
 	int tm2 = 0;