Re: syncing the disks when entering sleep

Leisner, Martin
2010-01-22T21:40:46Z

> -----Original Message-----
> From: Rafael J. Wysocki [mailto:rjw@sisk.pl]
> Sent: Friday, January 22, 2010 4:38 PM
> To: Leisner, Martin
> Cc: Nigel Cunningham; linux-pm@lists.linux-foundation.org
> Subject: Re: [linux-pm] syncing the disks when entering sleep
>
> On Friday 22 January 2010, Leisner, Martin wrote:
> > To clarify what I proposed:
> >
> > if(user sets knobs)
> > if(disk is spun up)
> > sync
> >
> > currently the algorithm is
> >
> > sync
>
> Yes, but Nigel said it should be
>
> if(user knob is unset)
> sync
>
> which I agree with.
>
> [BTW, please don't top-post in future.]
>
> Rafael

if(knob is set) {
if(disk is spun up)
sync
} else sync

The spinup of the disk can have a very noticeable amount of time...if the user doesn't care about syncing, then the top is preferred...

marty