From: Pavel Machek <pavel@ucw.cz>
To: Brian King <brking@linux.vnet.ibm.com>
Cc: linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH 1/1] PM: Add arch_suspend_disable_nonboot_cpus
Date: Tue, 23 Feb 2010 17:49:00 +0100 [thread overview]
Message-ID: <20100223164900.GG6220@elf.ucw.cz> (raw)
In-Reply-To: <4B84053D.60703@linux.vnet.ibm.com>
> > (Please wrap at column 80)
> >
> > This patch is already way better than the original one, but... Why do
> > you want enable/disable_nonboot_cpus to be noped out?
>
> Today for PPC_PSERIES, PM_SLEEP_SMP is never defined, so for all the
> current code paths that call enable/disable_nonboot_cpus (power off,
> kexec), these functions are noops. I don't want to change that
> behavior.
Why not?
> I figured I can just use the prepare_late and wake pm functions to do
> the work I need to do. Let me know if you think this is a reasonable
> approach and I'll be happy to resend the patch with an appropriate
> subject line and description.
No, I do not think that's reasonable approach. Please just implement
enable/disable_nonboot_cpus; that's the clean fix.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2010-02-23 16:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-21 16:32 [PATCH 1/1] PM: Add arch_suspend_disable_nonboot_cpus Brian King
[not found] ` <20100221191821.GA2198@ucw.cz>
2010-02-21 22:01 ` Brian King
[not found] ` <201002212308.52023.rjw@sisk.pl>
2010-02-21 22:22 ` Brian King
[not found] ` <201002212327.13399.rjw@sisk.pl>
2010-02-21 22:28 ` Brian King
[not found] ` <201002212337.10462.rjw@sisk.pl>
2010-02-21 22:46 ` Brian King
2010-02-22 19:14 ` Rafael J. Wysocki
2010-02-22 23:31 ` Brian King
2010-02-23 15:43 ` Pavel Machek
2010-02-23 16:41 ` Brian King
2010-02-23 16:49 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100223164900.GG6220@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-pm@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox